From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111367 invoked by alias); 6 Sep 2019 20:25:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111353 invoked by uid 89); 6 Sep 2019 20:25:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-30.7 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.210.65, H*RU:209.85.210.65, H*c:alternative X-HELO: mail-ot1-f65.google.com Received: from mail-ot1-f65.google.com (HELO mail-ot1-f65.google.com) (209.85.210.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2019 20:25:04 +0000 Received: by mail-ot1-f65.google.com with SMTP id b2so6937203otq.10 for ; Fri, 06 Sep 2019 13:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3eF4KIAZamI1B+cZ5DPjalPbyzzAVTRAqe/fpsbazF4=; b=TH5KZf36h4IqyK3HJ8n4qD/4vHEZCW1mJ1shNEmWRL1qplUn6yL/BpA05rpeTmLxUg QZodb5FV56Lxr+o/2JI1LLL3DYk2xuVZVnVmGN2lWm/rNh3bCM7UjAz4tZKoQ76lw0Wq PzlCs4Ik1WvFDmpg7RVKvMXqAqfv7oBacdhDy1H3qi8+OPd2xARHnK96KzZDaEMr1Ff5 9JfIPKYlCcBtgK93qGoah/xKu9TrvlyD843MlnEARZSu403opkBuG2pFHzqCikmu5vh7 v4dlmFns5f9Co/MeFufN3WsCbJrX6oxoF6nrx9TRoC1YZ9CEWTNZZnSp3zATlwfN+XJa wfVQ== MIME-Version: 1.0 References: <21336.14486.650610.274638@ruffy.mtv.corp.google.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 06 Sep 2019 20:25:00 -0000 Message-ID: Subject: Re: [patch] [gdb/testsuite] XFAIL under Clang tests using label debug info To: David Blaikie Cc: Eric Christopher , Douglas Evans , Pedro Alves , gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00073.txt.bz2 On Fri, Sep 6, 2019 at 3:23 PM David Blaikie wrote: > On Fri, Sep 6, 2019 at 10:26 AM Christian Biesinger > wrote: > > > > Thanks! So I think that requires clang 10? > > The fix was made last year (July 24, 2018) - so I think that means it > should be in Clang 7.0, though I haven't tested specifically. > Reading is hard :( Thanks. That certainly seems long enough ago that removing this is reasonable (but I'm not an approver) Christian > > > > > Christian > > > > On Thu, Sep 5, 2019 at 11:17 PM Eric Christopher > wrote: > >> > >> https://bugs.llvm.org/show_bug.cgi?id=14500#c3 has the relevant > information :) > > Thanks Eric! > > >> > >> On Thu, Sep 5, 2019, 7:48 PM Christian Biesinger via gdb-patches < > gdb-patches@sourceware.org> wrote: > >>> > >>> On Thu, Sep 5, 2019 at 5:12 PM David Blaikie > wrote: > >>> > > >>> > Clang now supports labels - so I'd like to essentially revert this > patch. > >>> > >>> Out of curiosity, when did clang get support for this? > >>> > >>> Christian > >>> > >>> > Is this OK? > >>> > > >>> > > >>> > On Thu, Apr 24, 2014 at 8:23 PM David Blaikie > wrote: > >>> > > > >>> > > On Wed, Apr 23, 2014 at 3:03 PM, Doug Evans > wrote: > >>> > > > David Blaikie writes: > >>> > > > > Clang doesn't emit debug info for labels (Clang PR14500). > XFAIL a > >>> > > > > bunch of GDB tests that rely on debug info for labels. > >>> > > > > > >>> > > > > For some reason gdb.linespec/ls-expr.exp gathered all tests > into a > >>> > > > > dictionary and then ran them. This made it hard to XFAIL just > the > >>> > > > > right tests. I refactored this to execute the tests directly, > removing > >>> > > > > the dictionary so I could XFAIL the right tests. Is there a > reason it > >>> > > > > would've been written that way? Does my patch break it in > some way? > >>> > > > > commit c438cb16b63292e415330f289616c4e4ecece63c > >>> > > > > Author: David Blaikie > >>> > > > > Date: Sun Apr 13 11:42:02 2014 -0700 > >>> > > > > > >>> > > > > XFAIL under Clang tests using labels > >>> > > > > > >>> > > > > gdb/testsuite/ > >>> > > > > * gdb.base/label.exp: XFAIL label related tests under > Clang. > >>> > > > > * gdb.cp/cplabel.exp: Ditto. > >>> > > > > * gdb.linespec/ls-errs.exp: Refactor tests to execute > directly > >>> > > > > and XFAIL under Clang those using labels. > >>> > > > > >>> > > > LGTM > >>> > > > > >>> > > > > diff --git gdb/testsuite/ChangeLog gdb/testsuite/ChangeLog > >>> > > > > index 730c116..b04b940 100644 > >>> > > > > --- gdb/testsuite/ChangeLog > >>> > > > > +++ gdb/testsuite/ChangeLog > >>> > > > > @@ -1,3 +1,9 @@ > >>> > > > > +2014-04-12 David Blaikie > >>> > > > > + > >>> > > > > + * gdb.base/label.exp: XFAIL label related tests > under Clang. > >>> > > > > + * gdb.cp/cplabel.exp: Ditto. > >>> > > > > + * gdb.linespec/ls-errs.exp: Refactor tests to execute > directly and XFAIL under Clang those using labels. > >>> > > > > + > >>> > > > > >>> > > > Nit: space vs tabs. Just use tabs. > >>> > > > Plus line is longer than 80 chars. > >>> > > > >>> > > Thanks for the catches - fixed those up and committed in > >>> > > c2e827ad5340fcf1735df6c77cb0311e56b985ef. > >>> > > > >>> > > Also refactored some of the xfails along the lines of what Pedro > >>> > > suggested in the one test case that had several similar failures > >>> > > (gdb.base/label.exp). If/when we fix this in Clang it might be > worth > >>> > > refactoring into a common function (though I'm personally not very > >>> > > vested in keeping the test suite usable with anything other than > ToT > >>> > > Clang - perhaps others are). >