From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18560 invoked by alias); 21 Sep 2019 02:20:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18529 invoked by uid 89); 21 Sep 2019 02:20:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.3 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:640 X-HELO: mail-oi1-f195.google.com Received: from mail-oi1-f195.google.com (HELO mail-oi1-f195.google.com) (209.85.167.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 21 Sep 2019 02:20:50 +0000 Received: by mail-oi1-f195.google.com with SMTP id o205so3355554oib.12 for ; Fri, 20 Sep 2019 19:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xf8mQtkY2yuY24wZM2pO4K1N3Syx/rFjiyMczNeunaw=; b=MlgcvYsfdC284GpnJuLtou7ev37AcD9WF4R4dtWT7JVVS8TqjyfaXtxJjuv8YaPptM oQ7CXYEyxnjbXvng/R2mP9qF7x29AxM/4aeiFmbPNv2S2/U/0zIXDym96eQP6uchn8Pg ZDVlaZ2FByNmLXIIOtBjpJvVPo6RChCd2v6bAD5bGuowCZ4G3XTRlXVEyPepKI/cOsO7 HGu2vw0HBWp0uXzhJ14H3Mz7WyfIW4jgFaAC3GaCeJwIjoiUuqlVIHDoxwwT167irsfT jfNGXA/fwyqmPolOAj9s8N3YZ+ABsmFB0jQvDbpwudCxZGvpSP3kf1CWmCXy4tIlUu3A kukw== MIME-Version: 1.0 References: <20190920025847.43084-1-cbiesinger@google.com> <744d88b3-c2af-0a98-c1ff-07ac898d7c5c@simark.ca> In-Reply-To: <744d88b3-c2af-0a98-c1ff-07ac898d7c5c@simark.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Sat, 21 Sep 2019 02:20:00 -0000 Message-ID: Subject: Re: [PATCH v4] Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00431.txt.bz2 On Fri, Sep 20, 2019 at 7:56 PM Simon Marchi wrote: > > On 2019-09-19 10:58 p.m., Christian Biesinger via gdb-patches wrote: > > All implementations of either function use it for the same purpose (except > > Darwin, which is a no-op): to prefer a symbol in the current objfile over > > symbols with the same name in other objfiles. There does not seem to be a > > reason to have both mechanisms for that purpose. > > Hi Christian, > > This LGTM, it is fine to push after the SPU removal patch. Thanks, pushed now. Christian