From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10369 invoked by alias); 13 Dec 2019 18:17:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127928 invoked by uid 89); 13 Dec 2019 18:15:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-17.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=it.=c2, H*c:alternative, HX-Spam-Relays-External:209.85.210.68, H*RU:209.85.210.68?= X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 18:15:44 +0000 Received: by mail-ot1-f68.google.com with SMTP id x3so80726oto.11 for ; Fri, 13 Dec 2019 10:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8RDwpZH1jW3EF8WxWSK/9uo3GcUV/GxwmKqo560Kd9M=; b=ljOHmBsGwWL9gP322u012P5ANcmTrl6wcnd2RbCM9fA4bHmdcdjK8jdgnjZT4/+T/9 ecEKno0vSe9IMqU02NW+WIRYyrHf29sS43e/JzBDNRRDp7mxKmej8sFMYqY7JEQxDdqc 9ssrdytQUl122dwX26RxpfyNN1bMY1gI6rBq7m8FYtDHz58Qm+I79VtVTIv6bv60NMHo B0trstFFtVyUm/A0z8j9EBw8GxObr4DQa4IbvSbRbdfZiLBFCQyUwjUe1PRNTjoyi3KY u+Bs0VTygwJO6c3E11aXRUXODCQrxyufz3+RX3MlQqVLOUbY4sEbgeOvaj3nmnMQ+ax8 hdwQ== MIME-Version: 1.0 References: <20191213060323.1799590-1-simon.marchi@polymtl.ca> <20191213060323.1799590-5-simon.marchi@polymtl.ca> <4eb506cf-b407-82b8-8f5d-e2c0481c431f@polymtl.ca> <5c3290f8-f1be-ab9f-986d-ab44d141da38@polymtl.ca> In-Reply-To: <5c3290f8-f1be-ab9f-986d-ab44d141da38@polymtl.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Fri, 13 Dec 2019 18:17:00 -0000 Message-ID: Subject: Re: [PATCH 4/7] jit: make gdb_symtab::blocks a vector To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00603.txt.bz2 On Fri, Dec 13, 2019, 11:14 Simon Marchi wrote: > On 2019-12-13 11:08 a.m., Christian Biesinger via gdb-patches wrote: > > I personally prefer this one. And maybe add a comment that the block that > > encloses the other one should come first? > > The order in which blocks appear in a blockvector is already explained in > the comment on > top of struct block, in block.h, so I didn't want to duplicate it. But I > can certainly > point to it explicitly in the comment above the std::sort call: > > /* Sort the blocks in the order they should appear in the blockvector. > > See the comment on top of struct block, in block.h, for more > details. */ > > Does that sound good? > Sounds good to me! >