From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id 4C61F3896C2B for ; Tue, 26 May 2020 16:43:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4C61F3896C2B Received: by mail-qt1-x841.google.com with SMTP id x29so3449024qtv.4 for ; Tue, 26 May 2020 09:43:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n/SavVU6YheFwFvs3mw3xe8nSBr+bW5HNa+bMKiasEE=; b=BlfcrPF9p4rm+6BlTTaQgLuykt4jQ+jfklwE95aLBxPGDzvPmQO8JLYa0ua7qoGXin dxlWRag61m2jIbRGQP3DpUHQrNRyU5n9IWBbYgLK6en4CDubz438HUi6JWrz4Z2lbFp8 Uh7B9gs+hLQUNUdHTHAwRQ/fzhI71GDmMqxLn3k7TyBaGH+jndgVQMPcVTxc4zcbxxBf hWprH26imwvW2HuxBkYFkEe18SN58KZR0Kh7NfFzOduwYOQopWIyN4iduRiuJaJSL8zM zOCwLv5BYg95R6F5YbVyks6D1GWAmyWkqh6KuAgf2XnSpQsW9eCCc3E58oDkESEXVr09 L2XQ== X-Gm-Message-State: AOAM530BNqtVvt78lHa3oc/ke728BukEdr7ZERVKtBTEF5iXOiVGw9Pr KRi1Zmg5ojVa+sza54hoObz48gXu0mFo6yzbIZEm7PAi4Tk= X-Google-Smtp-Source: ABdhPJwfOgQkLX2CIT5cEU6s0dPf8BiyQQQqeMGEEDf0GItVfcz0nFgtxp/VcHPYYSd4ItBk3S7RHjxujxT93jbr0fM= X-Received: by 2002:aed:35af:: with SMTP id c44mr2223556qte.349.1590511393585; Tue, 26 May 2020 09:43:13 -0700 (PDT) MIME-Version: 1.0 References: <20200525185659.59346-1-ssbssa@yahoo.de> <20200525185659.59346-3-ssbssa@yahoo.de> <1075658620.6710595.1590510315144@mail.yahoo.com> <14363667.6758276.1590511219831@mail.yahoo.com> In-Reply-To: <14363667.6758276.1590511219831@mail.yahoo.com> From: Christian Biesinger Date: Tue, 26 May 2020 11:42:36 -0500 Message-ID: Subject: Re: [PATCH 2/7] Handle Windows drives in auto-load script paths To: Hannes Domani Cc: Gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-19.5 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 16:43:15 -0000 On Tue, May 26, 2020 at 11:40 AM Hannes Domani via Gdb-patches wrote: > > Am Dienstag, 26. Mai 2020, 18:32:38 MESZ hat Christian Biesinger Folgendes geschrieben: > > > On Tue, May 26, 2020 at 11:25 AM Hannes Domani via Gdb-patches > > wrote: > > > > > > Am Dienstag, 26. Mai 2020, 18:05:57 MESZ hat Christian Biesinger Folgendes geschrieben: > > > > > > > On Mon, May 25, 2020 at 1:57 PM Hannes Domani via Gdb-patches > > > > wrote: > > > > > > > > > > Fixes this testsuite fail on Windows: > > > > > FAIL: gdb.base/auto-load.exp: print $script_loaded > > > > > > > > > > Converts the debugfile path from c:/dir/file to /c/dir/file, so it can be > > > > > appended to the auto-load path. > > > > > > > > How does this work? I thought /c/foo was not supported by either > > > > cygwin or mingw? > > > > > > Yes, but in this case we need a path that can be appended to the various > > > entries of 'set auto-load scripts-directory'. > > > c:/foo can't be appended, but /c/foo can. > > > So you would get something like c:/script/directory/c/foo. > > > > OK, so I *think* what you're saying is that if you have an objfile > > c:\foo\bar.dll, and an auto-load directory c:\load, then with this > > patch we will look for an auto-load script in > > c:\load\c\foo\bar.dll-gdb.py? Is that right? > > Basically, yes. > > > > If so, shouldn't there be a documentation update about how this works > > on Windows, and possibly a NEWS entry? > > A news entry that the bug was fixed? > From how I understand gdb.base/auto-load.exp, this is the way it was always > supposed to work (did I understand this wrong?). I don't feel so strongly about NEWS, but I specifically meant the translation of c:\ to c/ on Windows -- shouldn't that be documented? Christian