From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kFa3F/THdmFwdwAAWB0awg (envelope-from ) for ; Mon, 25 Oct 2021 11:06:28 -0400 Received: by simark.ca (Postfix, from userid 112) id 4FB281F0BD; Mon, 25 Oct 2021 11:06:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B37FF1EDDB for ; Mon, 25 Oct 2021 11:06:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB0F0385743A for ; Mon, 25 Oct 2021 15:06:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB0F0385743A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635174386; bh=ZF8BrCfLvzetbkXgM7JgPaGE90B7hnIqjSrcnHeDMBM=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=j4131qf+QG0wJn4j1abOSZVqh0H0NzQiWzF8rtnNjG5rsJIhQxq7+HbwQ+uWD3yS7 /jgbakt8ptHqBCD77ms+ZtDKvET0r1IQUivLKptG61kuaJWlX+Imlc106LpQhoVBr3 qEjOCN6U6Dsh6FDO+N57oLAnRV+We7NsQuKm/50M= Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by sourceware.org (Postfix) with ESMTPS id 867EC3857832 for ; Mon, 25 Oct 2021 15:05:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 867EC3857832 Received: by mail-qt1-x831.google.com with SMTP id n2so10563567qta.2 for ; Mon, 25 Oct 2021 08:05:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZF8BrCfLvzetbkXgM7JgPaGE90B7hnIqjSrcnHeDMBM=; b=YZRof98LY4BDo3D4B4PQ9/y2+zIaz3pSXHXTKy3RK+r+DQ0jYZhNde/QxWsXdmd5VD DkqCtbzRw/RLE/1gXxdsVHigEMBCQ5uwtCv9ufA65naFYRFG+RZ1wPseKRsANkjExvAl O3cZhMGMAKJ8YYzNF56BMfLuSjXLoNqZuKnW8HGTgDMmPYx4+LXX8zG9cvfeIYlp8tCp UhZ7zp7A+kHKdjZ0oEWf2hD7QpHv0cFMakPv9LMuYNxtw2uKYWpT6RA0ZqrX3xe4f8kM +DnR/TlR+kXsUZHODyHv/BZzKzPP/GlUuHJ7mT2/Z0+CqRc0GJKHIrFRFhilO1Vb8ywU yv5g== X-Gm-Message-State: AOAM530UGFAWyK9lifgUzODQklae1vZXgxTEoQTxmlQrSGk6mxkY2zIB hfewfYN5REt5usyIjl3wXP13nNnDMOG1t1rmGqmMtg== X-Google-Smtp-Source: ABdhPJwSdb7XGzEVczkp549batxoGAN9E1iFfpf0jkZYXIwFuGzBETFFNQiAP0hUMZLKIJnKyZN4nWV7poirjoWliSw= X-Received: by 2002:ac8:18c:: with SMTP id x12mr17948619qtf.378.1635174327796; Mon, 25 Oct 2021 08:05:27 -0700 (PDT) MIME-Version: 1.0 References: <20211025075244.1527116-1-orgads@gmail.com> In-Reply-To: <20211025075244.1527116-1-orgads@gmail.com> Date: Mon, 25 Oct 2021 11:04:50 -0400 Message-ID: Subject: Re: [PATCH] Fix using gnu print on mingw To: Orgad Shaneh Content-Type: text/plain; charset="UTF-8" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, Oct 25, 2021 at 3:53 AM Orgad Shaneh via Gdb-patches wrote: > > --- > bfd/bfd-in.h | 2 +- > bfd/bfd-in2.h | 2 +- > gdbsupport/format.h | 6 +++++- > gnulib/import/inttypes.in.h | 8 ++++---- > 4 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/bfd/bfd-in.h b/bfd/bfd-in.h > index 286afc607a3..6bb9622a514 100644 > --- a/bfd/bfd-in.h > +++ b/bfd/bfd-in.h > @@ -131,7 +131,7 @@ typedef BFD_HOST_U_64_BIT symvalue; > > #if BFD_HOST_64BIT_LONG > #define BFD_VMA_FMT "l" > -#elif defined (__MSVCRT__) > +#elif defined(__MSVCRT__) && !defined( __USE_MINGW_ANSI_STDIO) Can you elaborate some more on what problem this is solving and why this is the right way to solve it? I'm just guessing but maybe you instead want to check defined(__MINGW32__) || defined(__MINGW64__)? Christian