From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70849 invoked by alias); 15 Aug 2019 18:50:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70830 invoked by uid 89); 15 Aug 2019 18:50:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.3 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy= X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 18:49:59 +0000 Received: by mail-ot1-f67.google.com with SMTP id g17so6567018otl.2 for ; Thu, 15 Aug 2019 11:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V5uhq4eBsyfVz8Plgxbs+2N0Nu8ZQg7Gk3gavNgCcDw=; b=kIUBvbqNOP2D2kuKWQZf7OcQqPG2vMNyEtP5bKBZcs8Iz/EgOUGzn/Z/L4vwYpjgBn Tw9uUaxilf1y1e011KUpPnsg7Zc6aR5rVa4cIRuLgVeGdwdkTO6uT1zYwtAG2zhKT6n3 Z6GtHVtapRamroUrMsEc+fEmeRhdWWAYZ5dndCYkjS5kydFYwbAz98nQzER7XbCt5Yx4 +Dzlh5e8Cwpt0IoYW2lxfofLQJwBuSusEmE2sFpK01dz9iJfSLA5CGwpeOFULD1J6nbn 5yf05Qumnf4rDldPiEmC5uPAFS/OTQ7LQfalqDsI9ztVWBBSdIis0veeLNqu0vqcnYg6 oXrw== MIME-Version: 1.0 References: <20190815171541.134519-1-cbiesinger@google.com> <20190815174200.242339-1-cbiesinger@google.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 15 Aug 2019 18:50:00 -0000 Message-ID: Subject: Re: [PATCH v3] Make GDB compile with Python 3 on MinGW To: Pedro Alves Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00346.txt.bz2 Thanks, will send a patch in a second with that fixed (and which undoes the WIN32 ifdef change I accidentally had in the last version) Christian On Thu, Aug 15, 2019 at 1:02 PM Pedro Alves wrote: > > On 8/15/19 6:42 PM, Christian Biesinger via gdb-patches wrote: > > + error (_("Installation error: gdb._execute_file function is missing")); > > + return; > > That "return" statement is dead code, error throws an exception. > > Thanks, > Pedro Alves