Change in binutils-gdb[master]: Load system gdbinit files from a directory

Tom de Vries (Code Review)
2019-10-14T20:01:31Z

Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26 )

Change subject: Load system gdbinit files from a directory
......................................................................

Patch Set 1:

$ ../check_GNU_style.sh 0001-Load-system-gdbinit-files-from-a-directory.patch

Lines should not exceed 80 characters.
414:+ /* We effectively don't support "set script-extension off/soft",
422:+ sysgdbinit.insert (sysgdbinit.end (), files.begin (), files.end ());

Dot, space, space, end of comment.
78:+ moved. */

Sentences should end with a dot. Dot, space, space, end of the comment.
74:+/* automatically load system-wide gdbinit files from this directory */

There should be exactly one space between function name and parenthesis.
410:+ if (stat(filename.c_str (), &s) != 0 || !S_ISREG (s.st_mode))

--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings

Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2
Gerrit-Change-Number: 26
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom de Vries <tdevries@suse.de>
Gerrit-Comment-Date: Mon, 14 Oct 2019 20:01:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment