[review v5] Load system gdbinit files from a directory

Christian Biesinger (Code Review)
2019-10-24T19:05:29Z

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26
......................................................................

Uploaded patch set 5.

(3 comments)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c
File gdb/main.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/3/gdb/main.c@268
PS3, Line 268: if (dir != nullptr)
> Well, I think it looks a bit unnatural, but I don't have a strong opinion. […]
OK, I changed the indentation.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/4/gdb/main.c
File gdb/main.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/4/gdb/main.c@293
PS4, Line 293: files.push_back (filename);
> I think this could use `std::move (filename)`.
Done

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/4/gdb/main.c@1038
PS4, Line 1038: for (const std::string& file : system_gdbinit)
> should be " &file", not "& file" in the gdb style.
Thanks, done.

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2
Gerrit-Change-Number: 26
Gerrit-PatchSet: 5
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Tom de Vries <tdevries@suse.de>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 24 Oct 2019 19:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Comment-In-Reply-To: Tom Tromey <tromey@sourceware.org>
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment