From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62394 invoked by alias); 15 Aug 2019 16:15:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62372 invoked by uid 89); 15 Aug 2019 16:15:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-30.5 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy= X-HELO: mail-ot1-f66.google.com Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 16:15:48 +0000 Received: by mail-ot1-f66.google.com with SMTP id w4so6862066ote.11 for ; Thu, 15 Aug 2019 09:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cC+o0XN+MA+Xzv8HJ4t5kpTiaFeBu4KkUHYT7ekai8s=; b=CzhTUznKopgBZFBnuOzSR4SZZCmKVMLKXCk4IZ6Cxx5dwa4F/eL6w651CYr6oLgKgB dQfzW/Yik1xOVknintXu52LqGr6cIfbEZgLpnLT17I9hMZUSoHg45ATBFmrR4OLOQTBd 1ztMwde6f2Cy3OLbmF/ICq+VK8uyrrzC3Vm+c9WncZ5kikYbYPEelsAbcVIYAEM9wVql cgGo5C2o/P0Z/OG4q+8b7NpD3j4i1eYSw/xFDVkc87Yw4b55RtGxJumxLDluJMnXhjIf qbSxXkPym8+XTcBIOYQ//0kjpTxYX9+N4WXTQKhylLsQfXvfno8EyP8egXFM0rny+Wv7 LSZg== MIME-Version: 1.0 References: <20190814231502.78501-1-cbiesinger@google.com> <569e37f9-0e82-2565-f150-1fe50e76cc1e@redhat.com> In-Reply-To: <569e37f9-0e82-2565-f150-1fe50e76cc1e@redhat.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 15 Aug 2019 16:15:00 -0000 Message-ID: Subject: Re: [PATCH] [testsuite] Make the testsuite work on mingw To: Pedro Alves Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00327.txt.bz2 On Thu, Aug 15, 2019 at 10:56 AM Pedro Alves wrote: > On 8/15/19 12:15 AM, Christian Biesinger via gdb-patches wrote: > > Dejagnu produces an objdir like /c/, but GDB expects something like c:/. > > So fix it up in lib/gdb.exp. > > > > gdb/testsuite/ChangeLog: > > > > 2019-08-14 Christian Biesinger > > > > * lib/gdb.exp: When running on a mingw target, replace > > /x/ with x:/. > > --- > > gdb/testsuite/lib/gdb.exp | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > > index edc8dfcdfd..af56e8aa12 100644 > > --- a/gdb/testsuite/lib/gdb.exp > > +++ b/gdb/testsuite/lib/gdb.exp > > @@ -4724,6 +4724,10 @@ proc standard_output_file {basename} { > > > > set dir [make_gdb_parallel_path outputs $subdir $gdb_test_file_name] > > file mkdir $dir > > + # If running on MinGW, replace /c/foo with c:/foo > > OOC, does "on MinGW" mean using a Cygwin or MSYS2 dejagnu? > > Or are you really using a native MinGW expect/dejagnu? This was an MSYS dejagnu. (Hmm, I guess a cygwin one would require a different patch, to also match and remove /cygdrive... but I'll leave that to another time) I pushed this patch. Christian > > + if { [ishost *-*-mingw*] } { > > + set dir [regsub {^/([a-z])/} $dir {\1:/}] > > + } > > return [file join $dir $basename] > > } > > > > > > Thanks, > Pedro Alves