From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62374 invoked by alias); 5 Aug 2019 18:30:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62366 invoked by uid 89); 5 Aug 2019 18:30:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.5 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy= X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Aug 2019 18:30:42 +0000 Received: by mail-ot1-f68.google.com with SMTP id b7so36071174otl.11 for ; Mon, 05 Aug 2019 11:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hc5+h7BHW2YNUr5EFL3069PsTkJfW5j1WEaE07B4TvY=; b=kRhhVb7Th5rijQUKu6veKwqHbby1BYh5+ET+rrwUKc4NP3hpJ2/hs9acS0PWmfarX8 EY88/ncXpaKt7G2J09NOKsRsSpfJt1JRH1wzpPvujsZB9mIac9dSbDypU+6QuMC4veyL pgyJ9kQkTOWYY0or2Cj4vP7xerCp2ZeK71pfa+W/1XTBa2vWt5iDdAsWJf8mOoy2J/si DfiP3Qutece8F2F0tgV7ByIxpWyIkn39iJEHLFlGRPcUXVLWv61J+LxTJVXUOsqtn/K8 dpyV3TVbhPP/B1kqRpBnwzoccUVPT1jaGKuOF/kCG2TvZCI3dJET6N8OsIjgdaRR4fZe MYNA== MIME-Version: 1.0 References: <20190801223420.234581-1-cbiesinger@google.com> <87y30bit95.fsf@tromey.com> <6f69d3a0-e977-71c3-bcf3-dd619cd4cf99@simark.ca> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Mon, 05 Aug 2019 18:30:00 -0000 Message-ID: Subject: Re: [PATCH] Add block['var'] accessor To: Simon Marchi Cc: Tom Tromey , Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-08/txt/msg00124.txt.bz2 On Mon, Aug 5, 2019 at 1:28 PM Simon Marchi wrote: > > On 2019-08-05 14:19, Christian Biesinger wrote: > > On Mon, Aug 5, 2019 at 1:17 PM Simon Marchi wrote: > >> > >> On 2019-08-02 9:36 a.m., Tom Tromey wrote: > >> > Christian> + struct symbol *sym = block_lookup_symbol ( > >> > Christian> + block, name.get(), symbol_name_match_type::FULL, VAR_DOMAIN); > >> > > >> > What about looking up things in other domains? I wonder if it's > >> > possible to, say, have a local type that can be found by iteration over > >> > the block but not by dictionary access. If so, that seems confusing. > >> > >> Just wondering, was this commented responded to? > > > > Oh sorry, in the most recent version of the patch I fixed it by using > > ALL_BLOCK_SYMBOLS_WITH_NAME, which should match the behavior of the > > iterator afaict. > > Ok, thanks! > > Note that it helps others (including the reviewer) if you acknowledge > the comments, either with Ok / Done or "I'd rather not do that because > X". I did say at the top "Both issues should be fixed now." -- are you suggesting it's better to individually acknowledge them? I'd be happy to do that if y'all prefer. Christian