From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cbiesinger@google.com>
Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com
 [IPv6:2607:f8b0:4864:20::842])
 by sourceware.org (Postfix) with ESMTPS id 9E3F9388702C
 for <gdb-patches@sourceware.org>; Wed,  8 Apr 2020 17:18:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9E3F9388702C
Received: by mail-qt1-x842.google.com with SMTP id 13so459103qtt.5
 for <gdb-patches@sourceware.org>; Wed, 08 Apr 2020 10:18:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=uTfZvNLggEBvlIczolC29lRfB4tieSVRjcKXb16MbFE=;
 b=L67KK87+5ODOWw91nJk8zAMcjpHNGEW31EAuk26ITa4CF93K6MIs2xMqYPcIh+EgUK
 D+HtpC38JCMqsYXcqyuBqdrw1dBuRlBdNsSZlO+kckCujEutHQNn7xhQ8yJgC7pbF5E2
 Kr/wOJXWsyoGhDmg5m4qq7M3DEknrA9k3Rm1dc2320kJqavcIROrv88l/duIaH7rdYqI
 wAMDoNg88X9kU3lDB/TXn9JUp+1BR9Y4SzoQ+t/PV7JwafujH/S3xgqz5Hkc+5IKzlaU
 MG64hgi1+IRSSvxWcUAKLnlAWv1oD3jOb4Fqk5tMVM9wtfA+swxFK322/BySNu1fpRFW
 pAdA==
X-Gm-Message-State: AGi0PuaA0my2EQpMuOqcG+kl21x+NJrKqwvhlUQJ2kf3H8q+B7ttXaqu
 nB7AscQrFMB/wU0wZaSDWG1jhPWRSgNWniRCJCDZAQ==
X-Google-Smtp-Source: APiQypIhSaIipR2ae041p8VlL8o79bCJwxg4y1n3SyW9HQy1BoazZPAF+wxFH5x5zYEFN1r+Bzh45ZPnWb0hi0zC/+s=
X-Received: by 2002:aed:2b27:: with SMTP id p36mr7994354qtd.322.1586366321636; 
 Wed, 08 Apr 2020 10:18:41 -0700 (PDT)
MIME-Version: 1.0
References: <20200408171543.6061-1-n54@gmx.com>
In-Reply-To: <20200408171543.6061-1-n54@gmx.com>
From: Christian Biesinger <cbiesinger@google.com>
Date: Wed, 8 Apr 2020 12:18:04 -0500
Message-ID: <CAPTJ0XF-cLV=mHr4RjJON6cf1D=9xX+nyH6aQarseSoOpuqHQQ@mail.gmail.com>
Subject: Re: [PATCH] Tune default DEBUGDIR for NetBSD
To: Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-38.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Apr 2020 17:18:43 -0000

On Wed, Apr 8, 2020 at 12:16 PM Kamil Rytarowski <n54@gmx.com> wrote:
>
> NetBSD uses a custom debug file directory /usr/libdata/debug
> for the basesystem and does not use separate debug files in
> pkgsrc (3rd party package collections).
>
> gdb/ChangeLog:
>
>         * configure.ac: Handle NetBSD specific DEBUGDIR.
>         * configure: Regenerate.
> ---
>  gdb/ChangeLog    |  5 +++++
>  gdb/configure    | 11 ++++++++++-
>  gdb/configure.ac | 11 ++++++++++-
>  3 files changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 7ea85799211..af6844b6ace 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-04-08  Kamil Rytarowski  <n54@gmx.com>
> +
> +       * configure.ac: Handle NetBSD specific DEBUGDIR.
> +       * configure: Regenerate.
> +
>  2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
>
>         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
> diff --git a/gdb/configure b/gdb/configure
> index afafc2c8d18..636a3f69f00 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -6416,6 +6416,15 @@ if test x"$gdb_cv_have_makeinfo_click" = xyes; then
>  fi
>
>
> +case "${host}" in
> +  *-*-netbsd*)
> +    DEFAULTDEBUGDIR=/usr/libdata/debug

Wouldn't it be better to make this ${prefix}/libdata/debug?

> +    ;;
> +  *)
> +    DEFAULTDEBUGDIR=${libdir}/debug
> +    ;;
> +esac
> +
>
>
>  # Check whether --with-separate-debug-dir was given.
> @@ -6423,7 +6432,7 @@ if test "${with_separate_debug_dir+set}" = set; then :
>    withval=$with_separate_debug_dir;
>      DEBUGDIR=$withval
>  else
> -  DEBUGDIR=${libdir}/debug
> +  DEBUGDIR=${DEFAULTDEBUGDIR}
>  fi
>
>
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index b9dbe13232a..3cef95fbcb8 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -93,9 +93,18 @@ if test x"$gdb_cv_have_makeinfo_click" = xyes; then
>  fi
>  AC_SUBST(MAKEINFO_EXTRA_FLAGS)
>
> +case "${host}" in
> +  *-*-netbsd*)
> +    DEFAULTDEBUGDIR=/usr/libdata/debug
> +    ;;
> +  *)
> +    DEFAULTDEBUGDIR=${libdir}/debug
> +    ;;
> +esac
> +
>  GDB_AC_WITH_DIR(DEBUGDIR, separate-debug-dir,
>      [look for global separate debug info in this path @<:@LIBDIR/debug@:>@],
> -    [${libdir}/debug])
> +    [${DEFAULTDEBUGDIR}])
>
>  # We can't pass paths as command line arguments.
>  # Mingw32 tries to be clever and will convert the paths for us.
> --
> 2.25.0
>