From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26006 invoked by alias); 13 Aug 2019 19:59:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25998 invoked by uid 89); 13 Aug 2019 19:59:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.2 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=online X-HELO: mail-oi1-f172.google.com Received: from mail-oi1-f172.google.com (HELO mail-oi1-f172.google.com) (209.85.167.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Aug 2019 19:59:35 +0000 Received: by mail-oi1-f172.google.com with SMTP id o6so417803oic.9 for ; Tue, 13 Aug 2019 12:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nXmJd60s1CROHdZr7frH942CMrOmksUne2GDyLF8P88=; b=mNrl7GWY6vTPJ/3BF7keeZqJDUb5dQipbmX8hATYbIkcivrgK87sfoQxXiW9OffQAW 0TLsRLio6vX7JAo6eh36XJoPmdaPSkssL4Fq9QTQCj/GrXFWaVzxxCaGx/E/iGe6MjkB 2bdyl68gSUbpglfcsxHB6oH3r+bp9VEBooP3IfVJhajT//1Dfowaq2E+l2CjxKU9fLEr NtU33Xn04jO/mezgi5SUVggKNtlbvosfhzAnq5CM6xMlTR2atKRkAo1zSz11tI/4l4gG vxlo9ZtgS2SKvXYfrLBn4hlOo8a31QtlnF6r5wKqIIPccx4Ry1DwWR7xwdN3jUz9guU+ d6yQ== MIME-Version: 1.0 References: <20190813190436.215693-1-cbiesinger@google.com> <87blwsx305.fsf@tromey.com> In-Reply-To: <87blwsx305.fsf@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Tue, 13 Aug 2019 19:59:00 -0000 Message-ID: Subject: Re: [PATCH] [readline] Fix compilation on MinGW To: Tom Tromey Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00276.txt.bz2 On Tue, Aug 13, 2019 at 2:46 PM Tom Tromey wrote: > >>>>> "Christian" == Christian Biesinger via gdb-patches writes: > > Christian> S_ISLNK should not be called outside of an #ifdef. > Christian> However, this specific call is actually unnecessary, because > Christian> linkok can only be 0 if S_ISLNK is true, per the code above. > > Christian> I have sent a bug report to bug-readline, though it does not show > Christian> up in the online archive yet. > > I didn't see it show up there. I wonder if something went wrong. I also emailed Chet directly, hopefully that worked. > Christian> 2019-08-13 Christian Biesinger > > Christian> * colors.c (_rl_print_color_indicator): Remove unnecessary > Christian> S_ISLNK check to fix compilation on MinGW. > > This looks fine to me. Please check it in. Done. > It's important to be sure to follow up with upstream readline; and to > update the patch in the local tree if Chet uses a different patch. Will do. Christian