From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by sourceware.org (Postfix) with ESMTPS id 91240386F021 for ; Wed, 20 May 2020 19:24:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 91240386F021 Received: by mail-qk1-x741.google.com with SMTP id i5so4728965qkl.12 for ; Wed, 20 May 2020 12:24:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l2Luodx46zRkOg+FvVBPChTa+7xjwVJka+h5qmVYcYI=; b=TPCAWC5GWXndbeQjBEKnecFB7LPoNvLit9AO7gT2W2VgJYBcjdNFufKhluwzwEpDeW c/1uWcoSyYl8xjvR955Tf3oNLctW66q69Nwj1f1WUsSL/k1ZKPXbLlU9pzSaZOsWOocY dh+gS0RYkYzeVmlADKREjs0yCvcr8Xhok91zluRhdeCv3y/Yl38nQQwAsymBXnkLBxQ2 Jowxj+u9lKvJ7XzZ6zziSk6IsW4R/Nfc7P3Zlmyl3qa4mP4kVclEtal+W/shlRYW/lst 8ArUIY97e0PaVNvXU++JOeZl/5O0b02x7WYRT3rjfqo+27fkWM1XP9efhHB1CeqXGgW+ FAYg== X-Gm-Message-State: AOAM530oMPsLZ5sBOQwH7RYNnH6XvZCjy49p0yLaF1GTLJ41ISPi5UvQ zhntV0YX1BPSmrgOclyzVkRPS4T3V8sPU3L3DnWrN2nx X-Google-Smtp-Source: ABdhPJyeL/FtLnpZ/JE5dinMMLauhOLe9WcfP+fR2khbsUxwkf8VNeAd7A3re6voxl8WRQysFe1X7MeK6SIcyyr3yBA= X-Received: by 2002:a37:a551:: with SMTP id o78mr6028692qke.439.1590002692829; Wed, 20 May 2020 12:24:52 -0700 (PDT) MIME-Version: 1.0 References: <20200520192226.2889993-1-simon.marchi@efficios.com> In-Reply-To: <20200520192226.2889993-1-simon.marchi@efficios.com> From: Christian Biesinger Date: Wed, 20 May 2020 14:24:16 -0500 Message-ID: Subject: Re: [PATCH] gdb: reset/recompute objfile section offsets in reread_symbols To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-25.5 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2020 19:24:54 -0000 On Wed, May 20, 2020 at 2:22 PM Simon Marchi via Gdb-patches wrote: > diff --git a/gdb/symfile.c b/gdb/symfile.c > index dd8192a67fbb..b02a9235663b 100644 > --- a/gdb/symfile.c > +++ b/gdb/symfile.c > @@ -2543,6 +2543,11 @@ reread_symbols (void) > will need to be called (see discussion below). */ > obstack_free (&objfile->objfile_obstack, 0); > objfile->sections = NULL; > + objfile->section_offsets.clear (); > + objfile->sect_index_bss = -1; > + objfile->sect_index_data = -1; > + objfile->sect_index_rodata = -1; > + objfile->sect_index_text = -1; Would it make sense to have a reset() function on objfile instead, that handles all necesary clearing of members? Christian