From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36801 invoked by alias); 19 Jan 2020 16:42:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36793 invoked by uid 89); 19 Jan 2020 16:42:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-29.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1008, HX-Received:6f07, HX-Spam-Relays-External:209.85.210.67, H*RU:209.85.210.67 X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 19 Jan 2020 16:42:13 +0000 Received: by mail-ot1-f67.google.com with SMTP id 66so26614865otd.9 for ; Sun, 19 Jan 2020 08:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kFfXMc8+VRD/ySlmpxMuMU1kK5tTp75mCtTYc585LHM=; b=k+UeJbAglymUOiNt3J704mh0ClvSWwSVVKk75XMKEtXrWEipK5BKjbzUj9HlLW4vI0 u3EIvBDPowpeMXVD9chHB/OPIz3u/cJxxIe+V9zIUVbc+fjBk6Zjfblg0i1asrMQ5J12 WWXPtvggmeE4K62KUSAGHHIVM5M8YcMNT4rpiIiEHBClV4WdJKkOJRB+yJ43QFP1A8fz Otc4PR01xp9inwth0aINZF4iFz6FszpR4E098nv5/TwlpJN8aZotXFPt0Upr1yD0afa2 Ca1Hao+oghh5ITUJzsrKlgcdSeqSXo/+96G+Rq9cPXKXh5XbShosZi67X+wfr5ZJIoVm HHGw== MIME-Version: 1.0 References: <20200119161058.864-1-simon.marchi@polymtl.ca> In-Reply-To: <20200119161058.864-1-simon.marchi@polymtl.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Sun, 19 Jan 2020 16:53:00 -0000 Message-ID: Subject: Re: [PATCH] gdb/linux-fork: simplify one_fork_p To: Simon Marchi Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00586.txt.bz2 On Sun, Jan 19, 2020 at 11:11 AM Simon Marchi wrote: > > Unless I'm missing something, this function is a complicated way of > saying "fork_list.size () == 1". Before C++11, size() wasn't guaranteed to run in constant time, so I assume the code was written to handle that. But GDB uses C++11, so this change seems fine. https://en.cppreference.com/w/cpp/container/list/size > > gdb/ChangeLog: > > * linux-fork.c (one_fork_p): Simplify. > --- > gdb/linux-fork.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c > index 284f1985d0dc..357188685d07 100644 > --- a/gdb/linux-fork.c > +++ b/gdb/linux-fork.c > @@ -110,8 +110,7 @@ find_last_fork (void) > static bool > one_fork_p () > { > - return (!fork_list.empty () > - && &fork_list.front () == &fork_list.back ()); > + return fork_list.size () == 1; > } > > /* Add a new fork to the internal fork list. */ > -- > 2.24.1 >