From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33254 invoked by alias); 5 Feb 2020 18:02:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33246 invoked by uid 89); 5 Feb 2020 18:02:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.9 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Received:c70b, H*i:sk:CAPTJ0X, HX-Received:sk:x11mr39, H*r:ip*209.85.167.195 X-HELO: mail-oi1-f195.google.com Received: from mail-oi1-f195.google.com (HELO mail-oi1-f195.google.com) (209.85.167.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Feb 2020 18:02:50 +0000 Received: by mail-oi1-f195.google.com with SMTP id j132so1641759oih.9 for ; Wed, 05 Feb 2020 10:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ocFFnWIAA+7/EK+L7nVvYSKJVFUgVzw1I6gz5uvchFg=; b=nFXOhzdIED6C5muoJhe74j2vtrE9NwEhx/M6/67iJhsb14hfCAPk2XXjwzN1svB9As G5Go8HYCTAjUO57Oxzbh2nf/7MGClZt/9kIi8Mti52818ZJ0YBf/1h0pz0rXX3Nrso5f 4F74nLm0TKdF7lnBBGgVYr5T1lo9t/8NrMfJXvIfm94pB5zShXwbgacfd2e7Or8UzBLK t8haD8H9H/cESa90Rj4Jqf7feERcFBxdZetbNdEPwf/E1XWS/9LV1JHzQ8HRbzUK+FyP j0/r2H7r20TwH+5Qmouak0nZD54Uirt+dqhCKegGumizKtgbsyXyDdFBTX3j+3HpE0mc C8Nw== MIME-Version: 1.0 References: <20200124141458.171392-3-cbiesinger@chromium.org> <20200124141818.172490-1-cbiesinger@chromium.org> <2afe5687-5be2-7650-d4e3-3aceed3f68f2@gmx.com> <7432896e-39ec-4a99-cc07-77c684b71644@gmx.com> <8126c811-3416-a4d4-5a01-17776b0df999@gmx.com> <7a00a471-ab23-a235-d9bb-1d5d574bdacd@gmx.com> In-Reply-To: From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 05 Feb 2020 18:02:00 -0000 Message-ID: Subject: Re: [PATCH 2/3 v2] Define _KMEMUSER in arm-nbsd-nat.c To: Kamil Rytarowski Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00110.txt.bz2 On Mon, Jan 27, 2020 at 7:38 AM Christian Biesinger wrote: > > On Fri, Jan 24, 2020 at 5:37 PM Kamil Rytarowski wrote: > > > > On 24.01.2020 17:01, Christian Biesinger wrote: > > > On Fri, Jan 24, 2020 at 4:49 PM Kamil Rytarowski wrote: > > >> > > >> On 24.01.2020 16:35, Christian Biesinger via gdb-patches wrote: > > >>> On Fri, Jan 24, 2020 at 4:23 PM Kamil Rytarowski wrote: > > >>>> > > >>>> On 24.01.2020 15:53, Christian Biesinger via gdb-patches wrote: > > >>>>> Hi Kamil, > > >>>>> > > >>>>> I have a related question. NetBSD applied this patch: > > >>>>> https://www.mail-archive.com/tech@openbsd.org/msg44100.html > > >>>>> > > >>>> > > >>>> Is this the right link? > > >>> > > >>> Yeah -- that patch changes a system header at the top and patches GDB > > >>> at the bottom. > > >>> > > >> > > >> This is not a change in NetBSD, so it is unrelated. > > > > > > My apologies, I completely misread that. I'll see if I can find where > > > NetBSD changed their FP register data structure, or perhaps your > > > downstream patch will still work (although that probably has to come > > > from one of y'all for copyright reasons?) > > > > > > > Please cherry-pick what you need and I will find the original author. > > Many people in NetBSD have FSF papers done. > > Thanks. I think this patch would probably be the most important since > it fixes a compile error: > https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_arm-nbsd-nat.c > > However, I don't understand why arm_netbsd_core_fns / > fetch_core_registers was added. As far as I can tell, because that > struct uses bfd_target_unknown_flavour and default_core_sniffer, it > will never be used. Hi Kamil, I also filed https://github.com/NetBSD/pkgsrc-wip/issues/17 on some patches that can be dropped, and I upstreamed a couple of trivial/obvious patches you had. Christian