From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Rename "sun" variable to avoid conflicts on Solaris
Date: Thu, 19 Dec 2019 19:03:00 -0000 [thread overview]
Message-ID: <CAPTJ0XEij5pAppWydKL+4KeTF=p64Z2mqOpRe68-2iFPOLSj8g@mail.gmail.com> (raw)
In-Reply-To: <87v9qcb2pl.fsf@tromey.com>
On Thu, Dec 19, 2019 at 12:16 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
>
> Christian> A Solaris system header has a #define for "sun". This renames
> Christian> that variable to avoid the conflict, fixing a build error with
> Christian> --enable-targets=all on Solaris.
>
> Christian> gdb/ChangeLog:
>
> Christian> 2019-12-18 Christian Biesinger <cbiesinger@google.com>
>
> Christian> * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
> Christian> "sun" to "saddr_un".
>
> Thanks, this is ok.
Thanks, pushed.
To ssh://sourceware.org/git/binutils-gdb.git
78aa740b76..aa989b27d0 HEAD -> master
Christian
next prev parent reply other threads:[~2019-12-19 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 22:52 Christian Biesinger via gdb-patches
2019-12-19 18:16 ` Tom Tromey
2019-12-19 19:03 ` Christian Biesinger via gdb-patches [this message]
2019-12-19 0:01 [PATCH 0/3] Fix Solaris build with enable-targets=all Christian Biesinger via gdb-patches
2019-12-19 0:01 ` [PATCH] Rename "sun" variable to avoid conflicts on Solaris Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XEij5pAppWydKL+4KeTF=p64Z2mqOpRe68-2iFPOLSj8g@mail.gmail.com' \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox