From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G3yJA5IEkF8fEgAAWB0awg (envelope-from ) for ; Wed, 21 Oct 2020 05:51:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 016171EFC3; Wed, 21 Oct 2020 05:51:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 779D71E98E for ; Wed, 21 Oct 2020 05:51:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DAF863858C27; Wed, 21 Oct 2020 09:51:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAF863858C27 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1603273868; bh=gSWSF0uFd4n86J/UHlLtVGRTPx7izUCcL0wecaosevg=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Imhy6s6pE6CfvY0HNAVVZLBP9t1kYeHNdCoIef9RkD6Hm8qRJgah5GHTBT9XtQIIM tz+8K4DEBYmRdDxJIGZbpYxLvo45BHj16l1eO/xDJCm5NQ3wUgDr2lx8R9DGvZqBMF xQmxk8h4zu0Cy9lTUyHOfu+xmb8sk6yDnqJzebTs= Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by sourceware.org (Postfix) with ESMTPS id 7E2753858C27 for ; Wed, 21 Oct 2020 09:51:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E2753858C27 Received: by mail-qk1-x743.google.com with SMTP id h140so1695592qke.7 for ; Wed, 21 Oct 2020 02:51:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gSWSF0uFd4n86J/UHlLtVGRTPx7izUCcL0wecaosevg=; b=U5u7haozYhzwCgrq+rKCCoeTLXzyc2vohmOJbkZj46rAnGgthRjw62263zWKKLwG6E Lv2q4QLppbw7E3Y/xErNKyOGOj/ZgomON7T3v2/44uv3sEavks3ZNzR6IZZn8Je5wpht guk52nLdUbJAps18iS/e7Rikae0NfggVTvMceNFzzugs1xCqT7VjoPxlaEgRgYTOdYV4 ekBvwLVQzPqsk5TMfS6gOU7L8XSXl9Wnq5HyEGwZmQHNm0E1zpoVREmYwKuQaRwbDn4V lzbrkWtFnhIUfIvUeRYAl3gcs2mHisFRvHbrpR1M2hvEbo0gUm//Vi5NdnhFTcPzbCU5 iIbQ== X-Gm-Message-State: AOAM530ObezFydphpQHLXHFSsA9H4L9OXK+Z4EoEANwEdLdJHsz28YL2 e2UqNY+mHytHLQhLLly+aFJUdpRWV2wwjwzq+ZM50g== X-Google-Smtp-Source: ABdhPJxLXZRu/RcoRdCPyRwyHYeIE7Tu0Vq56DnXua9fmca0Xi3Rym3CGumrEmrS67TdPJlNDG8RB9wWBitbihK2zos= X-Received: by 2002:a37:a0d7:: with SMTP id j206mr2195619qke.375.1603273865871; Wed, 21 Oct 2020 02:51:05 -0700 (PDT) MIME-Version: 1.0 References: <20201020220453.302587-1-simon.marchi@polymtl.ca> In-Reply-To: <20201020220453.302587-1-simon.marchi@polymtl.ca> Date: Wed, 21 Oct 2020 11:50:29 +0200 Message-ID: Subject: Re: [PATCH] gdbserver: fix overlap in sprintf argument and buffer To: Simon Marchi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Biesinger via Gdb-patches Reply-To: Christian Biesinger Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wed, Oct 21, 2020 at 12:05 AM Simon Marchi via Gdb-patches wrote: > CXX server.o > /home/Baube/src/binutils-gdb/gdbserver/server.cc: In function =E2=80= =98void handle_general_set(char*)=E2=80=99: > /home/Baube/src/binutils-gdb/gdbserver/server.cc:832:12: error: =E2= =80=98sprintf=E2=80=99 argument 3 overlaps destination object =E2=80=98own_= buf=E2=80=99 [-Werror=3Drestrict] > 832 | sprintf (own_buf, "E.Unknown thread-events mode requested:= %s\n", > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~ > 833 | mode); > | ~~~~~ https://sourceware.org/bugzilla/show_bug.cgi?id=3D26758 was filed on this, so you should probably link to it in the commit message. + sprintf (own_buf, "%s", err.c_str ()); Why not use strcpy? Christian