From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76453 invoked by alias); 4 Jan 2020 21:45:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76371 invoked by uid 89); 4 Jan 2020 21:45:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.0 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*RU:209.85.210.66, HX-Spam-Relays-External:209.85.210.66, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f66.google.com Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Jan 2020 21:45:28 +0000 Received: by mail-ot1-f66.google.com with SMTP id a15so66065687otf.1 for ; Sat, 04 Jan 2020 13:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fx6XVndNRCokeeHAzhoHQcF8FPODxcwERlygsuKOsjA=; b=fSOlCp9SjvOSSptdfvR4BJpYJ1YBu8Ff6oysztCg/oclOD93ad667U/oI66KMe5+Yi MzEFtBvFMLPXb0B0j2hDoSJ+an3GmqFN0RC1Fg86yrKl7nf3FtsH4/giCA3lQ+otCD+E 4rOJH64xFvR+ceByAB18DI9/0vS9loOLK+JQZJ2k99SVvSguGZKFUskhM/IxD2QWT5Hf bK/MPCaBODx60P6vgplwjAvNUpaVSd0ZX8ogk5fI26JTAkgV3Er/dq6isrIMWd8Vb6R5 zoCaDopuuSBR2d4QVcre0sre+yd/acuw5hTtS8DbrQi2GAkuZtU5T/2aAl1QJuEUV3tF 02jQ== MIME-Version: 1.0 References: <20200104213701.14414-1-tom@tromey.com> In-Reply-To: <20200104213701.14414-1-tom@tromey.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Sat, 04 Jan 2020 21:45:00 -0000 Message-ID: Subject: Re: [PATCH] Make TUI borders respect "set style enabled" To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00086.txt.bz2 On Sat, Jan 4, 2020 at 4:37 PM Tom Tromey wrote: > > When adding support for styling the TUI borders, I neglected to have > this code check cli_styling. As a result, "set style enabled off" > does not affect the borders. > > This patch fixes this oversight. While doing this, I found that > running gdb without an executable, enabling the TUI, and then trying > "set style enabled off" would fail with the mysterious "No registers". > The fix for this is to use deprecated_safe_get_selected_frame in > tui_source_window_base::refill. So I don't know this code, but if you have to add a call to that function maybe it shouldn't be deprecated? Christian