From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88862 invoked by alias); 21 Aug 2019 18:08:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88733 invoked by uid 89); 21 Aug 2019 18:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.3 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*i:sk:87mug2h, H*f:sk:87mug2h X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 18:08:42 +0000 Received: by mail-ot1-f67.google.com with SMTP id j7so2915100ota.9 for ; Wed, 21 Aug 2019 11:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bHKyTL9hukhTJuQXbnSKW468DXCmeg8z1TvAExX3Xvw=; b=Ilw+W9Okfa2MqJbYwq1xhPy6HLPyietkpFjqunHwyjDaQDdLx7oGw+3X86gvn/0Zb+ Y4hYgGiVO3LNfrd6O0UvEhQw2cYFHW1/lLO7mr5OVQ69jJL20TpyZKveZ08nvhlUKu/A ESc/kqX45mIQLpZiLk0zkta9Eq2IXAyaOppCA/++HDD7Gb/JNJN3WrJH5NeszRtyTHlR gUm8KzlLB1nJkpASKu8gGYMzRgkm4wg6PV9AJB2R4QXP31rtA/fsHsctP5Mh7VYBGn6v f2Gsjdevx9rWNJqicTJmZkog4nUlEWvCbMLYwrh4pxHA/FFybVQwvdN3hgbpm1EWCPIy kg4g== MIME-Version: 1.0 References: <20190820221745.147370-1-cbiesinger@google.com> <20190820221745.147370-3-cbiesinger@google.com> <87r25ejv1r.fsf@redhat.com> <87mug2h0lp.fsf@redhat.com> In-Reply-To: <87mug2h0lp.fsf@redhat.com> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Wed, 21 Aug 2019 18:08:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit To: Sergio Durigan Junior Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00501.txt.bz2 On Wed, Aug 21, 2019 at 12:47 PM Sergio Durigan Junior wrote: > > On Wednesday, August 21 2019, Christian Biesinger wrote: > > > On Wed, Aug 21, 2019 at 12:19 PM Sergio Durigan Junior > > wrote: > >> > >> On Tuesday, August 20 2019, Christian Biesinger via gdb-patches wrote: > >> > >> > gdb/ChangeLog: > >> > > >> > 2019-08-20 Christian Biesinger > >> > > >> > * main.c (relocate_gdbinit_path_maybe_in_datadir): New function. > >> > (get_init_files): Update. > >> > >> I'm afraid you'll need a descriptive commit message :-). > > > > Changed to: > > > > 2019-08-20 Christian Biesinger > > > > * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code > > out of get_init_files. > > (get_init_files): Update. > > > > (I guess the title of the commit message is not enough?) > > Sorry, I should have been more clear. > > The changelog entry was fine; I was referring to the actual commit > message (the text you write before the changelog). I think a very > simple text should be enough in this case, since it's a refactorization. Oh OK, changed to the following: Factor out the code to do the datadir-relocation for gdbinit This simplifies get_init_files and makes it possible to reuse this code in an upcoming patch for SYSTEM_GDBINIT_DIR. gdb/ChangeLog: 2019-08-20 Christian Biesinger * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code out of get_init_files. (get_init_files): Update. (I assume it's fine not to resend the full patch, but let me know if you want me to) Christian