From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60088 invoked by alias); 1 Aug 2019 17:46:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60079 invoked by uid 89); 1 Aug 2019 17:46:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-32.2 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1599, HX-HELO:sk:mail-ot X-HELO: mail-ot1-f66.google.com Received: from mail-ot1-f66.google.com (HELO mail-ot1-f66.google.com) (209.85.210.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Aug 2019 17:46:07 +0000 Received: by mail-ot1-f66.google.com with SMTP id z23so46842203ote.13 for ; Thu, 01 Aug 2019 10:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1qRobDx6SfVAqBe9Mh+p7UECjuqf0JXgGGWQ0k1URfQ=; b=WTkFETyxOuGa+/myjX2pKZugd9mV3y9v75jbnz21j9PNjBaAiXB/OXh1hNjfTT3o5H nP3M+ECbi/pbBJhhayU55dUREUWEv1WjyA3VngIYcX6gYXX9jxcAduwSZObFv9EvUJ7q iyKtSpdngw8Sy0BA/HRXBgU704dKzADLlXePGzzbv2SPvBcR4Od2hMpd3/C2ORVLGzng iL/o7TcgOxdO4ZuiAbZJDwvnvbd1GoxvRMxGI4PtyS/oOnQJZllzbwthLt67n0C7ykM9 J/yKkXyyChhcbwtrXINgFU3WM9y0zzQrhaaCAFiPZ/PYfuDEyp1+LcWM15YSZ3ckTtZa o/LQ== MIME-Version: 1.0 References: <20190801170141.198456-1-cbiesinger@google.com> <20190801172647.64620-1-cbiesinger@google.com> <814c05fb-299d-8d95-fb0b-c8cde820b0d6@simark.ca> In-Reply-To: <814c05fb-299d-8d95-fb0b-c8cde820b0d6@simark.ca> From: "Christian Biesinger via gdb-patches" Reply-To: Christian Biesinger Date: Thu, 01 Aug 2019 17:46:00 -0000 Message-ID: Subject: Re: [PATCH] Include s12z-opc.h using ../opcodes. To: Simon Marchi Cc: Christian Biesinger via gdb-patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2019-08/txt/msg00025.txt.bz2 On Thu, Aug 1, 2019 at 12:30 PM Simon Marchi wrote: > > On 2019-08-01 1:26 p.m., Christian Biesinger via gdb-patches wrote: > > This file exists in binutils-gdb/opcodes, and nothing in Makefile.in adds this > > to the include path. Default builds work because in-tree readline adds > > binutils-gdb/ to the include path (!). However, this is broken when compiling > > with system readline. > > Yeah, my guess is that the include path is added when using the in-tree readline to make > #include "readline/readline.h" work. And it made this include work by chance. > > > Other files already use this way to include files in opcodes: > > ./gdb/lm32-tdep.c:#include "../opcodes/lm32-desc.h" > > ./gdb/or1k-tdep.h:#include "../opcodes/or1k-desc.h" > > ./gdb/mep-tdep.c:#include "../opcodes/mep-desc.h" > > > > etc. > > > > gdb/ChangeLog: > > > > 2019-08-01 Christian Biesinger > > > > * s12z-tdep.c: Fix include path for s12z-opc.h. > > --- > > gdb/s12z-tdep.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > > index a9d20e809c..a1c085cfbb 100644 > > --- a/gdb/s12z-tdep.c > > +++ b/gdb/s12z-tdep.c > > @@ -30,7 +30,7 @@ > > #include "opcode/s12z.h" > > #include "trad-frame.h" > > #include "remote.h" > > -#include "opcodes/s12z-opc.h" > > +#include "../opcodes/s12z-opc.h" > > > > /* Two of the registers included in S12Z_N_REGISTERS are > > the CCH and CCL "registers" which are just views into > > > Thanks, the patch LGTM. Thanks, pushed.