Re: m2-typeprint.c:m2_range's use of TYPE_DOMAIN_TYPE: Eh?

Doug Evans
2015-01-21T04:15:33Z

On Tue, Jan 20, 2015 at 2:25 PM, Gaius Mulley
<gaius.mulley@southwales.ac.uk> wrote:
> Doug Evans <xdje42@gmail.com> writes:
>
>> Hi.
>>
>> Does anyone know why m2_range uses TYPE_DOMAIN_TYPE here?
>>
>> [...]
>> Alas, vptr_basetype is overloaded and is used also for TYPE_DOMAIN_TYPE:
>>
>> #define TYPE_DOMAIN_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->vptr_basetype
>>
>> hence wondering why in the world m2_range is using it. :-)
>
> Hi Doug,
>
> feel free to clean up the code and make it comply with other languages.
> I've a feeling that this code will need an overhaul against gm2-1.1.1
> (grafted on gcc-4.7.4). The gcc/gm2 interface has pretty much all
> been rewritten since gm2-1.0 (which was grafted onto gcc-4.1.2).

Thanks.
Alas cleaning up this code is non-obvious.
What do I replace TYPE_DOMAIN_TYPE with?
I'm tempted to just go with TYPE_TARGET_TYPE
and let y'all fix it later if that's wrong.

>
>> For TYPE_CODE_{MEMBERPTR,METHODPTR,METHOD},
>> any reason why their "domain type" (I'll want to rename that)
>> cannot live in type_specific?
>>
>> ---
>>
>> void
>> m2_range (struct type *type, struct ui_file *stream, int show,
>> int level, const struct type_print_options *flags)
>> {
>> if (TYPE_HIGH_BOUND (type) == TYPE_LOW_BOUND (type))
>> m2_print_type (TYPE_DOMAIN_TYPE (type), "", stream, show, level,
>> flags);
>> else
>> {
>> struct type *target = TYPE_TARGET_TYPE (type);
>>
>> fprintf_filtered (stream, "[");
>> print_type_scalar (target, TYPE_LOW_BOUND (type), stream);
>> fprintf_filtered (stream, "..");
>> print_type_scalar (target, TYPE_HIGH_BOUND (type), stream);
>> fprintf_filtered (stream, "]");
>> }
>> }
>
> regards,
> Gaius