From: Doug Evans <xdje42@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Ludovic Courtès" <ludo@gnu.org>
Subject: Re: [PATCH] record_latest_value: Call release_value_or_incref instead of release_value
Date: Mon, 03 Mar 2014 06:02:00 -0000 [thread overview]
Message-ID: <CAP9bCMTxDz1R2NOZcvW3cByOrjy5qsRDnKeCvyJpcP0hQU33RA@mail.gmail.com> (raw)
In-Reply-To: <m3zjl7u8ik.fsf@sspiff.org>
On Sun, Mar 2, 2014 at 10:00 PM, Doug Evans <xdje42@gmail.com> wrote:
> Hi.
>
> While testing a fix for bug 16612 I was getting segvs and traced it to
> the new history-append! Scheme function.
>
> The underlying gdb value was getting prematurely freed when its
> Scheme wrapper was garbage collected, but it was still in the value
> history.
>
> I think this is because its reference counting is wrong.
> Upon return from record_latest_value, its reference count is still one.
> However it was one upon entry. It should be two, right?
> One for the Scheme wrapper and one for the history entry.
Apologies for the followup.
I should have said "However it was one upon entry and the value had
already been released."
The value gets released when creating the Scheme wrapper.
next prev parent reply other threads:[~2014-03-03 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 6:00 Doug Evans
2014-03-03 6:02 ` Doug Evans [this message]
2014-03-03 9:17 ` Ludovic Courtès
2014-03-03 13:23 ` Joel Brobecker
2014-03-03 15:50 ` Ludovic Courtès
2014-03-03 16:20 ` Doug Evans
2014-03-03 16:22 ` Doug Evans
2014-03-13 16:34 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP9bCMTxDz1R2NOZcvW3cByOrjy5qsRDnKeCvyJpcP0hQU33RA@mail.gmail.com \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox