From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5534 invoked by alias); 2 Aug 2015 17:42:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5524 invoked by uid 89); 2 Aug 2015 17:42:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f177.google.com Received: from mail-yk0-f177.google.com (HELO mail-yk0-f177.google.com) (209.85.160.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 02 Aug 2015 17:42:35 +0000 Received: by ykoo205 with SMTP id o205so4476502yko.0 for ; Sun, 02 Aug 2015 10:42:33 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.170.198.144 with SMTP id p138mr15688741yke.70.1438537353166; Sun, 02 Aug 2015 10:42:33 -0700 (PDT) Received: by 10.13.233.198 with HTTP; Sun, 2 Aug 2015 10:42:33 -0700 (PDT) In-Reply-To: <55BC89E6.9040705@adacore.com> References: <55AE7520.1010307@adacore.com> <55AE943F.3000009@adacore.com> <55BA299D.7040407@adacore.com> <55BC89E6.9040705@adacore.com> Date: Sun, 02 Aug 2015 17:42:00 -0000 Message-ID: Subject: Re: [PATCH] Replace the block_found global with explicit data-flow From: Doug Evans To: Pierre-Marie de Rodat Cc: GDB Patches , Pedro Alves Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00008.txt.bz2 On Sat, Aug 1, 2015 at 1:57 AM, Pierre-Marie de Rodat wrote: > On 07/30/2015 03:41 PM, Pierre-Marie de Rodat wrote: >>> >>> LGTM with the rename and the following nits fixed. >> >> >> Great, thanks again! Here's the updated patch, rebased on master and >> re-tested on x86_64-linux. I'll wait for tomorrow before pushing it in >> order give anyone a chance to object. :-) > > > This is pushed, now. Hi. The changelog entry still says "symbol_in_block". That'll need to be fixed. No need to include a changelog entry denoting the changelog entry was fixed :-) (IMO). Just commit a patch that corrects the original entry.