Re: target-delegates.c needs some TLC [was Re: [OB PATCH] target.h (to_traceframe_info): Fix TARGET_DEFAULT_RETURN]

Yao Qi
2014-03-10T02:47:39Z

On 03/06/2014 01:20 PM, Doug Evans wrote:
> While I realize we don't want to require perl for building gdb (and I
> for one would never advocate it), I wonder if we can do at least a bit
> better.

perl is required by git, and GDB source is version controlled by git.
I assume that most of the host machine used for gdb development have
git and perl installed. People may get source from release, and
generate patch on top of it (without git/perl installed). It isn't
common, is it?

Anyway, we can check whether perl is installed. If perl is installed,
run make-target-delegates during make and error out if new-generated
target-delegates.c is different from the one in gdb source. Is it good?
If yes, I'll submit a patch for this.

Using --enable-maintainer-mode or adding new --enable-foo option isn't
appealing to me.

--
Yao (é½å°§)