From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119419-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27885 invoked by alias); 29 Jan 2015 07:28:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27850 invoked by uid 89); 29 Jan 2015 07:28:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wi0-f175.google.com
Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 29 Jan 2015 07:28:34 +0000
Received: by mail-wi0-f175.google.com with SMTP id fb4so21805111wid.2        for <gdb-patches@sourceware.org>; Wed, 28 Jan 2015 23:28:31 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.194.61.65 with SMTP id n1mr15918146wjr.36.1422516511630; Wed, 28 Jan 2015 23:28:31 -0800 (PST)
Received: by 10.27.39.198 with HTTP; Wed, 28 Jan 2015 23:28:31 -0800 (PST)
In-Reply-To: <20150129071929.GE5193@adacore.com>
References: <m33876ary6.fsf@sspiff.org>	<54C0E1FF.4050201@redhat.com>	<m3egqe83x3.fsf@sspiff.org>	<20150129071929.GE5193@adacore.com>
Date: Thu, 29 Jan 2015 10:01:00 -0000
Message-ID: <CAP9bCMTGqCfLQx78wRBhG3JCA10tfZ3d5fpagU-bsCf6f2G5Qg@mail.gmail.com>
Subject: Re: [PATCH][PR symtab/17855] Fix.
From: Doug Evans <xdje42@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00753.txt.bz2

On Wed, Jan 28, 2015 at 11:19 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Aargh - I was working on it just now because I wasn't sure if anyone
> felt they "had the ball on their court".
>
>> Like so?
>>
>> 2015-01-28  Doug Evans  <xdje42@gmail.com>
>>
>>       PR symtab/17855
>>       * symfile.c (clear_symtab_users): Move call to breakpoint_re_set
>>       closer to end.
>
> What I've tested is moving the call last, as shown in the attached
> diff.  Not technically necessarily better, but as the comment explains,
> I move it last so that it's after we've purged all relevant caches.
> That way, the function is organized in two rough sections:
>   - do purges first;
>   - do updates next.
> Your comment is a lot more detailed, I like it.

I think yours is fine too.
I'm ok with using it.