From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28826 invoked by alias); 2 Dec 2013 17:01:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28777 invoked by uid 89); 2 Dec 2013 17:01:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.7 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f182.google.com Received: from Unknown (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 02 Dec 2013 17:01:00 +0000 Received: by mail-wi0-f182.google.com with SMTP id en1so5144368wid.3 for ; Mon, 02 Dec 2013 09:00:51 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.62.8 with SMTP id u8mr2984800wjr.68.1386003650946; Mon, 02 Dec 2013 09:00:50 -0800 (PST) Received: by 10.194.37.73 with HTTP; Mon, 2 Dec 2013 09:00:50 -0800 (PST) In-Reply-To: <87eh5vwaa3.fsf@fleche.redhat.com> References: <87eh5vwaa3.fsf@fleche.redhat.com> Date: Mon, 02 Dec 2013 17:01:00 -0000 Message-ID: Subject: Re: [PATCH] include/gdb/section-scripts.h: New file. From: Doug Evans To: Tom Tromey Cc: Doug Evans , gdb-patches@sourceware.org, binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00044.txt.bz2 On Mon, Dec 2, 2013 at 7:19 AM, Tom Tromey wrote: >>>>>> "Doug" == Doug Evans writes: > > Doug> This patch creates a file to use when adding values to > Doug> .debug_gdb_scripts. > > I don't see why this needs to go in include. So you would have code that puts contents in this section using magic numbers? Eh? This doesn't make any sense. Why does dwarf2.def exist (for example) ? [The dwarf format is far more complicated, obvously. But I didn't know there was a threshold of magic numbers was required before a header was allowed.] > I think it would be more helpful to document the format of this section > in the manual. Documentation can always be improved, but there is something there already. I do need to spiff it up, that's coming ... > Doug> +/* Native GDB scripts are not currently supported in .debug_gdb_scripts, > Doug> + but we reserve a value for it. */ > Doug> +/*#define SECTION_SCRIPT_ID_GDB_FILE 2*/ > > There's no need either to reserve a value or to add commented out code. I'm curious how I would apply this rule in general.