From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7451 invoked by alias); 14 Nov 2014 17:19:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7441 invoked by uid 89); 14 Nov 2014 17:19:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f42.google.com Received: from mail-yh0-f42.google.com (HELO mail-yh0-f42.google.com) (209.85.213.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 14 Nov 2014 17:19:14 +0000 Received: by mail-yh0-f42.google.com with SMTP id b6so9106335yha.15 for ; Fri, 14 Nov 2014 09:19:12 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.170.189.133 with SMTP id g127mr7280128yke.100.1415985552010; Fri, 14 Nov 2014 09:19:12 -0800 (PST) Received: by 10.170.81.68 with HTTP; Fri, 14 Nov 2014 09:19:11 -0800 (PST) In-Reply-To: <5464D8A2.9020004@ericsson.com> References: <5464D8A2.9020004@ericsson.com> Date: Fri, 14 Nov 2014 17:19:00 -0000 Message-ID: Subject: Re: [PATCH 00/21] struct symtab split part 2 From: Doug Evans To: Simon Marchi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00328.txt.bz2 On Thu, Nov 13, 2014 at 8:13 AM, Simon Marchi wrote: >[...] > As someone who never quite understood who the symtab mechanism worked in gdb, > I welcome this change very much It makes the data structure a bit more > self-descriptive, which in turn helps understanding the algorithms used. Agreed. > That lovely ascii art chart makes things very clear, and I would even suggest > including it somewhere in the code (symtab.h I guess). Good idea, will do. > Thanks a lot for your work. Thanks.