From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23283 invoked by alias); 23 Nov 2013 19:12:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23273 invoked by uid 89); 23 Nov 2013 19:12:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.2 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-wi0-f170.google.com Received: from Unknown (HELO mail-wi0-f170.google.com) (209.85.212.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 23 Nov 2013 19:12:17 +0000 Received: by mail-wi0-f170.google.com with SMTP id hq4so2365466wib.1 for ; Sat, 23 Nov 2013 11:12:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.94.137 with SMTP id dc9mr2577989wjb.38.1385233928276; Sat, 23 Nov 2013 11:12:08 -0800 (PST) Received: by 10.194.37.73 with HTTP; Sat, 23 Nov 2013 11:12:08 -0800 (PST) In-Reply-To: <528C8F1E.2080309@redhat.com> References: <1382366424-21010-1-git-send-email-sanimir.agovic@intel.com> <1382366424-21010-7-git-send-email-sanimir.agovic@intel.com> <528C8F1E.2080309@redhat.com> Date: Sat, 23 Nov 2013 19:27:00 -0000 Message-ID: Subject: Re: [PATCH 06/10] vla: update type from newly created value From: Doug Evans To: Pedro Alves Cc: Sanimir Agovic , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00717.txt.bz2 On Wed, Nov 20, 2013 at 2:29 AM, Pedro Alves wrote: > On 10/21/2013 03:40 PM, Sanimir Agovic wrote: >> Constructing a value based on a type and address might change the type >> of the newly constructed value. > > OOC (and for the archives), why's that? Where does that occur? > >> Thus re-fetch type via value_type to ensure >> we have the correct type at hand. Not just for the archives. I didn't find it in the patch series, but I could have missed it of course. I think a VERY LOUD comment needs to be added to these routines to tell the reader "HEADS UP! If you do after calling me, then you MUST also do ." [or words to that effect]