Re: [patchv3 2/2] Accelerate lookup_symbol_aux_objfile 85x

Jan Kratochvil
2014-12-03T18:05:19Z

On Tue, 02 Dec 2014 04:06:28 +0100, Doug Evans wrote:
> I was reviewing all the callers of lookup_symbol_in_objfile_symtabs.

I do not see why, see below.

> This patch assumes we're looping over all objfiles,

No. each objfile is considered completely independent wrt various kinds of
symbol tables and their inter-refefences.

Function block_lookup_symbol_primary() assumes we're looping over all
'compunit_symtabs's (of an objfile). This is satisfied by the current only
caller of block_lookup_symbol_primary()
(which is lookup_symbol_in_objfile_symtabs()).

> but some callers aren't. e.g., lookup_symbol_in_objfile_from_linkage_name.
> It seems like we'll need to make a copy of lookup_symbol_in_objfile_symtabs
> and call that in lookup_symbol_in_objfile (plus I'd add some comments
> to lookup_symbol_in_objfile warning the reader that included symtabs
> are not searched).
>
> I could be missing something though.

I also can be missing something but I do not see why
block_lookup_symbol_primary() should have any dependencies on other objfiles
than the one that is passed to it.

Thanks,
Jan