From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28304 invoked by alias); 16 Jan 2015 16:32:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28295 invoked by uid 89); 16 Jan 2015 16:32:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f178.google.com Received: from mail-we0-f178.google.com (HELO mail-we0-f178.google.com) (74.125.82.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 16 Jan 2015 16:32:18 +0000 Received: by mail-we0-f178.google.com with SMTP id p10so21136459wes.9 for ; Fri, 16 Jan 2015 08:32:15 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.60.19 with SMTP id d19mr29837704wjr.48.1421425935077; Fri, 16 Jan 2015 08:32:15 -0800 (PST) Received: by 10.27.39.198 with HTTP; Fri, 16 Jan 2015 08:32:15 -0800 (PST) In-Reply-To: <837fwn2cvc.fsf@gnu.org> References: <83k3149k5b.fsf@gnu.org> <837fwn2cvc.fsf@gnu.org> Date: Fri, 16 Jan 2015 16:32:00 -0000 Message-ID: Subject: Re: [PATCH] TUI: Expand TABs into spaces From: Doug Evans To: Eli Zaretskii Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00465.txt.bz2 On Fri, Jan 16, 2015 at 3:17 AM, Eli Zaretskii wrote: > Ping! OK to install, master and 7.9 branch? > >> Date: Sat, 03 Jan 2015 13:30:08 +0200 >> From: Eli Zaretskii >> >> "gdb -tui" relies on the curses library and the underlying terminal >> driver to expand TAB characters into spaces. But ncurses on Windows >> doesn't do that, and instead displays an IBM graphics character. >> >> The patches below fix that in the command window and in displaying the >> registers. >> >> OK to commit? >> >> 2015-01-03 Eli Zaretskii >> >> * tui/tui-regs.c (tui_register_format): Expand TABs into the >> appropriate number of spaces. >> >> * tui/tui-io.c (tui_puts, tui_redisplay_readline): Expand TABs >> into the appropriate number of spaces. I'd have to read the patch more to say it's ok, but one thing that is missing are comments explaining *why* we are expanding tabs into spaces.