From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107277-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3343 invoked by alias); 17 Nov 2013 17:59:06 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3334 invoked by uid 89); 17 Nov 2013 17:59:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=2.0 required=5.0 tests=AWL,BAYES_40,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2
X-HELO: mail-we0-f176.google.com
Received: from Unknown (HELO mail-we0-f176.google.com) (74.125.82.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 17 Nov 2013 17:59:05 +0000
Received: by mail-we0-f176.google.com with SMTP id w62so5325483wes.35        for <gdb-patches@sourceware.org>; Sun, 17 Nov 2013 09:58:55 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.194.185.73 with SMTP id fa9mr13740399wjc.29.1384711135798; Sun, 17 Nov 2013 09:58:55 -0800 (PST)
Received: by 10.194.37.73 with HTTP; Sun, 17 Nov 2013 09:58:55 -0800 (PST)
In-Reply-To: <CAP9bCMQa7g0vupyHKwmZKum1QJDToDL7bCj92Sc6xbV9R71KGg@mail.gmail.com>
References: <CAA8o+=Q2ur7dAZYRRgOeRV1=KW_2azOwRY8meVHYKaOx3Yh9GQ@mail.gmail.com>	<527AB482.80600@earthlink.net>	<87ppqd1a0t.fsf@fleche.redhat.com>	<m3li10bsbj.fsf@seba.sebabeach.org>	<87r4asz3be.fsf@fleche.redhat.com>	<CAA8o+=T2a8WLE8zi1NO=u8B460KmwOvA2m2pzVJCkAsXw6vHBw@mail.gmail.com>	<CAA8o+=RBU=AkLmW=Q+J16jZgJZ-Fpp8nPajK-FDH-AyrEJgQyQ@mail.gmail.com>	<CAA8o+=RLzeC6o8X2ZBsc_HGq_aJAUYVGuyWJe49No9UcyAS4yA@mail.gmail.com>	<m34n7lbbb9.fsf@seba.sebabeach.org>	<CAP9bCMQa7g0vupyHKwmZKum1QJDToDL7bCj92Sc6xbV9R71KGg@mail.gmail.com>
Date: Sun, 17 Nov 2013 19:34:00 -0000
Message-ID: <CAP9bCMSKMw1h6UVobEz_7R01OQFS8EoL8mf0podqiYGhBCzRrw@mail.gmail.com>
Subject: Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c
From: Doug Evans <xdje42@gmail.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Stan Shebs <stanshebs@earthlink.net>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
X-SW-Source: 2013-11/txt/msg00444.txt.bz2

On Thu, Nov 14, 2013 at 9:24 AM, Doug Evans <xdje42@gmail.com> wrote:
> On Sat, Nov 9, 2013 at 11:54 AM, Doug Evans <xdje42@gmail.com> wrote:
>> Ok, no more attachment.
>>
>> 2013-11-09  Doug Evans  <xdje42@gmail.com>
>>
>>         * gdbtypes.c: #include bcache.h, dwarf2loc.h.
>>         (type_equality_entry): Move here from python/py-type.c.
>>         (type_equality_entry_d): Ditto.
>>         (compare_maybe_null_strings, check_types_equal): Ditto.
>>         (check_types_worklist, types_deeply_equal): Ditto.
>>         * gdbtypes.h (types_deeply_equal): Declare.
>>         * python/py-type.c: Remove inclusion of bcache.h, dwarf2loc.h.
>>         (typy_richcompare): Update.
>
> Ping.

Since this is just a simple cleanup, there's no real need to put
someone to the trouble of doing a code review so I think I'm just
going to check this in.

Guess I should have just submitted it that way in the first place.
Good thing to know for next time.