From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24290 invoked by alias); 17 Feb 2014 20:59:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24281 invoked by uid 89); 17 Feb 2014 20:59:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f43.google.com Received: from mail-yh0-f43.google.com (HELO mail-yh0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 17 Feb 2014 20:59:24 +0000 Received: by mail-yh0-f43.google.com with SMTP id z6so14419519yhz.2 for ; Mon, 17 Feb 2014 12:59:22 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.236.206.114 with SMTP id k78mr188732yho.145.1392670762503; Mon, 17 Feb 2014 12:59:22 -0800 (PST) Received: by 10.170.93.10 with HTTP; Mon, 17 Feb 2014 12:59:22 -0800 (PST) In-Reply-To: <834n3x8o7m.fsf@gnu.org> References: <834n3x8o7m.fsf@gnu.org> Date: Mon, 17 Feb 2014 20:59:00 -0000 Message-ID: Subject: Re: [PATCH v2] Improved ^c support for gdb/guile From: Doug Evans To: Eli Zaretskii Cc: "gdb-patches@sourceware.org" , guile-devel@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00545.txt.bz2 [+ guile-devel] On Mon, Feb 17, 2014 at 12:43 PM, Eli Zaretskii wrote: >> From: Doug Evans >> Date: Mon, 17 Feb 2014 15:26:27 -0500 >> >> Unworkable-as-is optimization trying to avoid queueing asyncs. Blech. >> >> I'm still seeing intermittent testsuite failures because Guile is >> getting an uncaught SIGINT. > > Bother: is this the only way to fix these issues (whatever they are)? > Because you are quickly getting into non-Windows lands, so there's a > real risk that the Guile support will not be very useful on Windows > (except with Cygwin). The Guile developers are looking into providing a better way to do this for 2.2 so all is not lost. :-) >> +void >> +gdbscm_initialize_sigint (void) >> +{ >> + siscm_sigint_pipe[0] = siscm_sigint_pipe[1] = -1; >> + >> + if (!SCM_USE_PTHREAD_THREADS) >> + { >> + warning (_("Guile does not have pthreads support.")); >> + warning (_("Proper SIGINT handling for Guile will be unavailable.")); >> + return; >> + } > > The above is what worries me. Guile currently doesn't work in the > native MinGW build if configured with threads (it crashes, hangs, > etc.). Can't we have decent SIGINT handling without pthreads? With 2.0.x, no. I'm ok with changing the warning, e.g., not printing it at all on systems where it would otherwise always be printed, and instead documenting the issue for such systems. The downside is that while Scheme code is running SIGINT is ignored (unless one is in the repl, or sets up a SIGINT handler oneself). For lots of uses of Guile in GDB it's not a total loss.