From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112290-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13851 invoked by alias); 11 May 2014 05:17:07 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11613 invoked by uid 89); 11 May 2014 05:17:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yk0-f180.google.com
Received: from mail-yk0-f180.google.com (HELO mail-yk0-f180.google.com) (209.85.160.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 11 May 2014 05:17:04 +0000
Received: by mail-yk0-f180.google.com with SMTP id q9so4862538ykb.39        for <gdb-patches@sourceware.org>; Sat, 10 May 2014 22:17:02 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.236.87.139 with SMTP id y11mr29499835yhe.27.1399785422409; Sat, 10 May 2014 22:17:02 -0700 (PDT)
Received: by 10.170.222.7 with HTTP; Sat, 10 May 2014 22:17:02 -0700 (PDT)
In-Reply-To: <20140509153305.GA13345@blade.nx>
References: <20140509100656.GA4760@blade.nx>	<201405091120.s49BKO1f010622@glazunov.sibelius.xs4all.nl>	<20140509153305.GA13345@blade.nx>
Date: Sun, 11 May 2014 05:17:00 -0000
Message-ID: <CAP9bCMRmZOcMtdKfZZHVCdYat3MqiaK8-RWGzJ3SQW7MViSr6w@mail.gmail.com>
Subject: Re: [PATCH 0/2] Demangler crash handler
From: Doug Evans <xdje42@gmail.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00128.txt.bz2

On Fri, May 9, 2014 at 8:33 AM, Gary Benson <gbenson@redhat.com> wrote:
> [...]
> +  if (crash_signal != 0)
> +    {
> +      static int warning_printed = 0;
> +
> +      if (!warning_printed)
> +       {
> +         warning ("internal error: demangler failed with signal %d\n"
> +                  "Unable to demangle '%s'\n"
> +                  "This is a bug, "
> +                  "please report it to the GDB maintainers.",
> +                  crash_signal, name);
> +
> +         warning_printed = 1;
> +       }
> +
> +      result = NULL;
> +    }
> +
> +  return result;

Hi.

Applying "Consistency Is Good" to this patch,
I wonder if we should do something similar to what we do for internal errors.
I'm not sure I would use the same flag (grep for
internal_problem_modes and friends in utils.c), but
OTOH I wouldn't want a proliferation of options for controlling each
particular kind of "crash".

What do you think?