From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118948-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13540 invoked by alias); 11 Jan 2015 23:48:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13511 invoked by uid 89); 11 Jan 2015 23:48:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-we0-f174.google.com
Received: from mail-we0-f174.google.com (HELO mail-we0-f174.google.com) (74.125.82.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 11 Jan 2015 23:48:21 +0000
Received: by mail-we0-f174.google.com with SMTP id k48so16390360wev.5        for <gdb-patches@sourceware.org>; Sun, 11 Jan 2015 15:48:18 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.194.7.103 with SMTP id i7mr15384198wja.53.1421020098154; Sun, 11 Jan 2015 15:48:18 -0800 (PST)
Received: by 10.27.39.198 with HTTP; Sun, 11 Jan 2015 15:48:18 -0800 (PST)
In-Reply-To: <CAP9bCMSCfKUGi0KJtStRFhyJurhv-JpKtjt3VC=fJgMDwMUhyA@mail.gmail.com>
References: <m3fvbrpt5s.fsf@seba.sebabeach.org>	<CAP9bCMSCfKUGi0KJtStRFhyJurhv-JpKtjt3VC=fJgMDwMUhyA@mail.gmail.com>
Date: Sun, 11 Jan 2015 23:48:00 -0000
Message-ID: <CAP9bCMReEwvtqEnqWwd_DPhPu-FA=vrSyAt1agQuJyPnJN8P=Q@mail.gmail.com>
Subject: Re: [PATCH] dwarf.exp: All numeric attributes require a form
From: Doug Evans <xdje42@gmail.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00282.txt.bz2

On Sat, Jan 3, 2015 at 11:25 AM, Doug Evans <xdje42@gmail.com> wrote:
> On Sat, Jan 3, 2015 at 11:21 AM, Doug Evans <xdje42@gmail.com> wrote:
>> Hi.
>>
>> As a followup to this patch:
>> https://sourceware.org/ml/gdb-patches/2015-01/msg00020.html
>>
>> this patch flags as an error any numeric attribute that doesn't
>> specify a form.  And lo and behold I found more bugs. :-)
>>
>> Regression tested on amd64-linux.
>>
>> 2015-01-03  Doug Evans  <xdje42@gmail.com>
>>
>>         * lib/dwarf.exp (Dwarf): Flag an error if a numeric attribute value
>>         is given without an explicit form.
>>         * gdb.dwarf2/arr-subrange.exp: Specify forms for all numeric
>>         attributes.
>>         * gdb.dwarf/corrupt.exp: Ditto.
>>         * gdb.dwarf2/enum-type.exp: Ditto.
>>         * gdb.trace/entry-values.exp: Ditto.
>>         * gdb.trace/unavailable-dwarf-piece.exp: Ditto.
>
> btw,
> I did think of using a more complete test than just "string is integer".
> I'm happy with whatever y'all decide.
>
> I decided against trying to guess the form for numeric attributes,
> there's just too many to choose from.

fyi, I committed this.