From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17221 invoked by alias); 5 Jun 2014 16:10:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17211 invoked by uid 89); 5 Jun 2014 16:10:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f179.google.com Received: from mail-yk0-f179.google.com (HELO mail-yk0-f179.google.com) (209.85.160.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 05 Jun 2014 16:10:16 +0000 Received: by mail-yk0-f179.google.com with SMTP id q200so402995ykb.24 for ; Thu, 05 Jun 2014 09:10:14 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.236.83.204 with SMTP id q52mr66648565yhe.65.1401984614721; Thu, 05 Jun 2014 09:10:14 -0700 (PDT) Received: by 10.170.150.70 with HTTP; Thu, 5 Jun 2014 09:10:14 -0700 (PDT) In-Reply-To: <20140605145053.GA15133@blade.nx> References: <20140605145053.GA15133@blade.nx> Date: Thu, 05 Jun 2014 16:10:00 -0000 Message-ID: Subject: Re: Remove conditionals for ANSI-standard signals From: Doug Evans To: Gary Benson Cc: "gdb-patches@sourceware.org" , Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00273.txt.bz2 On Thu, Jun 5, 2014 at 7:50 AM, Gary Benson wrote: > Hi all, > > This patch removes all preprocessor conditionals for ANSI-standard > signals (SIGINT, SIGILL, SIGABRT, SIGFPE, SIGSEGV and SIGTERM) which > are guaranteed to always be defined. > > Built and regtested on RHEL6.5 x86_64. > > Ok to commit? > > Cheers, > Gary > > -- > gdb/ > 2014-06-05 Gary Benson > > * common/signals.c: Remove preprocessor conditionals for > always-defined signals SIGINT, SIGILL, SIGABRT, SIGFPE, > SIGSEGV and SIGTERM. > * proc-events.c: Likewise. Ok, with one request. IWBN to have one more patch after this one, as its preferable to move code around as a separate patch. I can't see any sorting order to the places that have all the #ifdefs (common/signals.c in particular), and I wonder if it would be useful to put the non-#ifdef'd signals first with a comment explaining why they don't have #ifdefs. One could also sort them alphabetically of course too, of course, within each group (non-#ifdef, #ifdef), but I don't have a strong opinion on that.