From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6457 invoked by alias); 17 Nov 2014 01:34:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6445 invoked by uid 89); 17 Nov 2014 01:34:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f181.google.com Received: from mail-yk0-f181.google.com (HELO mail-yk0-f181.google.com) (209.85.160.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 17 Nov 2014 01:34:42 +0000 Received: by mail-yk0-f181.google.com with SMTP id 142so4608101ykq.12 for ; Sun, 16 Nov 2014 17:34:39 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.236.207.164 with SMTP id n24mr22300633yho.17.1416188079449; Sun, 16 Nov 2014 17:34:39 -0800 (PST) Received: by 10.170.81.68 with HTTP; Sun, 16 Nov 2014 17:34:39 -0800 (PST) In-Reply-To: References: <87d29cvqfu.fsf@codesourcery.com> <87y4rfjm9h.fsf@codesourcery.com> <20141116032213.GF5774@adacore.com> Date: Mon, 17 Nov 2014 01:34:00 -0000 Message-ID: Subject: Re: [PATCH 7/9] Rewrite lookup_static_symbol to use gdbarch routine From: Doug Evans To: Joel Brobecker Cc: Yao Qi , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00388.txt.bz2 On Sun, Nov 16, 2014 at 1:53 PM, Doug Evans wrote: > On Sat, Nov 15, 2014 at 7:22 PM, Joel Brobecker wrote: >> Hi Doug, >> >>> To keep things moving along I added the copyright headers. >> >> Thanks for doing that. >> >>> However, I think we could be a bit more lax when it comes to >>> such trivial testcases. >> >> The FSF allows us to be lax for trivial files (with 10 lines being >> one explicit limit on triviality). But: >> >> The problem with being lax is that it creates a little extra work >> for us at the start of each year, when we update the copyright headers. >> The FSF has been asking us to look into copyright headers in the past, >> and it was a lot of work, so I've added a bit of simple-minded code >> to the script that updates the copyright headers in GDB to also issue >> a warning if a copyright header hasn't been found. That way, we can >> then investigate the few problematic files each year rather than >> a massive number when the FSF notices something. >> >> That's why I always appreciate the copyright headers being added >> right from the start. >> >> So, again, thanks a lot for adding those! :) > > No worries. > A few more words added to the wiki to added the needed context and > clarity would be great. > I'll do that. Hmmm, I see that in gdb the convention is "Copyright (C)" whereas in the gdb/testsuite the convention is "Copyright" with no "(C)". Some tests have "(C)" but the vast majority don't. Both are allowed, and I'm not planning on going through and changing anything. Just thought I'd point it out.