From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14724 invoked by alias); 20 Feb 2014 17:18:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14713 invoked by uid 89); 20 Feb 2014 17:18:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f45.google.com Received: from mail-yh0-f45.google.com (HELO mail-yh0-f45.google.com) (209.85.213.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 20 Feb 2014 17:18:22 +0000 Received: by mail-yh0-f45.google.com with SMTP id i57so999472yha.18 for ; Thu, 20 Feb 2014 09:18:20 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.236.204.74 with SMTP id g50mr4693107yho.127.1392916700771; Thu, 20 Feb 2014 09:18:20 -0800 (PST) Received: by 10.170.130.14 with HTTP; Thu, 20 Feb 2014 09:18:20 -0800 (PST) In-Reply-To: <20140219075900.GC4270@adacore.com> References: <1390374431-17981-1-git-send-email-manjian2006@gmail.com> <20140128120600.GG4101@adacore.com> <20140210142831.GY5485@adacore.com> <20140211021937.GD5485@adacore.com> <20140213073112.GS5485@adacore.com> <52FC7BC8.2010400@gmail.com> <20140214033411.GD5485@adacore.com> <20140219075900.GC4270@adacore.com> Date: Thu, 20 Feb 2014 17:18:00 -0000 Message-ID: Subject: Re: PING: [PATCH v4] fixed inherit_abstract_dies infinite recursive call From: Doug Evans To: Joel Brobecker Cc: lin zuojian , "gdb-patches@sourceware.org" , Tom Tromey , linzj Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00650.txt.bz2 On Tue, Feb 18, 2014 at 11:59 PM, Joel Brobecker wrote: >> Hi. >> Sorry for the delay! > > No, Thank You for looking into it! :) > >> I spent some time looking for a cleverer patch, but in the end I think the >> simplicity of this patch is nice. > > :) > >> >> 2014-02-18 lin zuojian >> Joel Brobecker >> Doug Evans >> >> PR symtab/16581 >> * dwarf2read.c (struct die_info): New member in_process. >> (reset_die_in_process): New function. >> (process_die): Set it at the start, reset when returning. >> (inherit_abstract_dies): Only call process_die if origin_child_die >> not already being processed. >> >> testsuite/ >> * gdb.dwarf2/dw2-icycle.S: New file. >> * gdb.dwarf2/dw2-icycle.c: New file. >> * gdb.dwarf2/dw2-icycle.exp: New file. > > That looks good to me, with one tiny little CS comment (see below). > >> +static void >> +reset_die_in_process (void *arg) >> +{ >> + struct die_info *die = arg; >> + die->in_process = 0; > > Missing empty line after local variable declaration. Committed. [with a small tweak to the testcase (added a comment)]