From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19562 invoked by alias); 18 May 2014 23:26:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19516 invoked by uid 89); 18 May 2014 23:26:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f170.google.com Received: from mail-yk0-f170.google.com (HELO mail-yk0-f170.google.com) (209.85.160.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 18 May 2014 23:26:40 +0000 Received: by mail-yk0-f170.google.com with SMTP id 10so3971924ykt.1 for ; Sun, 18 May 2014 16:26:38 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.236.52.74 with SMTP id d50mr47627103yhc.44.1400455598097; Sun, 18 May 2014 16:26:38 -0700 (PDT) Received: by 10.170.150.70 with HTTP; Sun, 18 May 2014 16:26:38 -0700 (PDT) In-Reply-To: <1400253995-12333-6-git-send-email-tromey@redhat.com> References: <1400253995-12333-1-git-send-email-tromey@redhat.com> <1400253995-12333-6-git-send-email-tromey@redhat.com> Date: Sun, 18 May 2014 23:26:00 -0000 Message-ID: Subject: Re: [PATCH 05/14] change how the CLI handles comments From: Doug Evans To: Tom Tromey Cc: "gdb-patches@sourceware.org" , Phil Muldoon Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00323.txt.bz2 On Fri, May 16, 2014 at 8:26 AM, Tom Tromey wrote: > From: Phil Muldoon > > When using the multi-line feature, we don't want the gdb CLI to remove > comments from the command list, as this will remove things like > "#define". > > This patch moves the comment feature into command_loop to avoid this > problem. > > 2014-05-16 Phil Muldoon > > * top.c (command_loop): Handle comments here... > (command_line_input): ... not here. > --- > gdb/ChangeLog | 5 +++++ > gdb/top.c | 20 +++++++------------- > 2 files changed, 12 insertions(+), 13 deletions(-) > > diff --git a/gdb/top.c b/gdb/top.c > index fa20025..16694e6 100644 > --- a/gdb/top.c > +++ b/gdb/top.c > @@ -560,11 +560,14 @@ command_loop (void) > > make_command_stats_cleanup (1); > > - execute_command (command, instream == stdin); > - > - /* Do any commands attached to breakpoint we are stopped at. */ > - bpstat_do_actions (); > + /* Do not execute commented lines. */ > + if (command[0] != '#') > + { > + execute_command (command, instream == stdin); > > + /* Do any commands attached to breakpoint we are stopped at. */ > + bpstat_do_actions (); > + } > do_cleanups (old_chain); > } > } > @@ -1057,15 +1060,6 @@ command_line_input (char *prompt_arg, int repeat, char *annotation_suffix) > if (*linebuffer && input_from_terminal_p ()) > add_history (linebuffer); > > - /* Note: lines consisting solely of comments are added to the command > - history. This is useful when you type a command, and then > - realize you don't want to execute it quite yet. You can comment > - out the command and then later fetch it from the value history > - and remove the '#'. The kill ring is probably better, but some > - people are in the habit of commenting things out. */ > - if (*p1 == '#') > - *p1 = '\0'; /* Found a comment. */ > - > /* Save into global buffer if appropriate. */ > if (repeat) > { > -- > 1.9.0 > Hi. I have an equivalent patch that I need for guile support. E.g., guile (foo #:bar 42) end Since this is really independent of the rest of the patch set, can this be checked in right away? TIA