From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81297 invoked by alias); 14 Feb 2017 16:22:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81283 invoked by uid 89); 14 Feb 2017 16:22:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=corrections, H*f:sk:9676A09, H*i:sk:9676A09 X-HELO: mail-yw0-f175.google.com Received: from mail-yw0-f175.google.com (HELO mail-yw0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 16:22:14 +0000 Received: by mail-yw0-f175.google.com with SMTP id w75so69014213ywg.1 for ; Tue, 14 Feb 2017 08:22:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yJ/iw11PDy88CpE8/TX6afdjNvZGWAZ5D2xyRCQ3cI0=; b=jBtFQQQGfEGeW9l+r1dz/S0B/F4+lwQwz/+lChWhyDWwE51JTSu424DKERgwuTBvAc auiFe9aYDNk99+95CIrBnDNVmYSzVQvqf92uRUO0V/dJ8piopTdP0FgDIAFJV18B6/He NItX+Ega5XyMN2MS7jPbjdwPeYAZIE3c2+NR06+thd/0zd3fyCG0F7aa3B4QTKe8VQCD NVo06D8m7sPToP2Y2VuSl8EDESjEdlwOAsQJ6x8RHA9HSs/ku2TPJAqJxpeYMUiLeldO ZB2Fqr3D6zcbXtpR3X0fT73iI2BLs+7BvK16J50xZANfJcRnPqzJlIUEiIY88yMc8g+i SEIA== X-Gm-Message-State: AMke39noMRU4KyHyh+8QbcEtm3l93TyNSovMskGIYb6u2Yd8na/6W0VU3sd3bXtFReRogUgbpKB19YC1L29MCw== X-Received: by 10.129.96.67 with SMTP id u64mr23303429ywb.331.1487089332987; Tue, 14 Feb 2017 08:22:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.109.144 with HTTP; Tue, 14 Feb 2017 08:22:12 -0800 (PST) In-Reply-To: <9676A094AF46E14E8265E7A3F4CCE9AF94021F@irsmsx105.ger.corp.intel.com> References: <1486989450-11313-1-git-send-email-tim.wiederhake@intel.com> <9676A094AF46E14E8265E7A3F4CCE9AF94021F@irsmsx105.ger.corp.intel.com> From: Doug Evans Date: Tue, 14 Feb 2017 16:22:00 -0000 Message-ID: Subject: Re: [PATCH v6 0/9] Python bindings for btrace recordings To: "Wiederhake, Tim" Cc: "gdb-patches@sourceware.org" , "Metzger, Markus T" , "palves@redhat.com" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00388.txt.bz2 On Tue, Feb 14, 2017 at 2:18 AM, Wiederhake, Tim wrote: > Hi all, > >> > Is this good to go? >> LGTM > > ... And in return I made a mess. What should have been a "git push --dry-= run" to prepare for pushing this, ended up as an actual push. The commits n= ow miss the actual ChangeLog entries and contain some "Change-Id" lines. Be= fore I start fiddeling and probably make things worse, could you tell me ho= w to properly resolve this? > > Thanks, > Tim Hi. I suppose technically the Right thing to do is to revert it all and recommit with the ChangeLog changes. But it's not like we never make post-commit corrections to just ChangeLogs. Perhaps not on this scale, but I'm totally ok with just ignoring the Change-Id lines and adding the ChangeLog entries as a separate patch.