From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2869 invoked by alias); 23 Jan 2015 16:14:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2820 invoked by uid 89); 23 Jan 2015 16:14:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f45.google.com Received: from mail-wg0-f45.google.com (HELO mail-wg0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 23 Jan 2015 16:14:18 +0000 Received: by mail-wg0-f45.google.com with SMTP id x12so8367107wgg.4 for ; Fri, 23 Jan 2015 08:14:15 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.237.202 with SMTP id ve10mr15938228wjc.36.1422029655815; Fri, 23 Jan 2015 08:14:15 -0800 (PST) Received: by 10.27.39.198 with HTTP; Fri, 23 Jan 2015 08:14:15 -0800 (PST) In-Reply-To: <83h9vhu7k8.fsf@gnu.org> References: <1417094168-25868-1-git-send-email-gbenson@redhat.com> <1417094168-25868-4-git-send-email-gbenson@redhat.com> <20141210122233.GA7299@blade.nx> <21671.20308.262958.475080@ruffy2.mtv.corp.google.com> <20150107084255.GA17867@blade.nx> <21680.36641.315766.209208@ruffy2.mtv.corp.google.com> <83a91r6lbd.fsf@gnu.org> <20150115153930.GA14900@blade.nx> <83h9vhu7k8.fsf@gnu.org> Date: Fri, 23 Jan 2015 16:38:00 -0000 Message-ID: Subject: Re: [PATCH 3/3 v2] Implement completion limiting From: Doug Evans To: Eli Zaretskii Cc: Gary Benson , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00653.txt.bz2 On Fri, Jan 23, 2015 at 2:15 AM, Eli Zaretskii wrote: >> +/* Return a message indicating that the maximum number of completions >> + has been reached and that there may be more. */ >> + >> +const char * >> +get_max_completions_reached_message (void) >> +{ >> + return _("*** List may be truncated, max-completions reached. ***"); >> +} > > I'd prefer a different wording: > > (More completions follow; omitted because max-completions exceeded.) > > My problem with your wording is two-fold: > > . "may be truncated" can be interpreted to the effect that GDB > doesn't know whether truncation really happened; I think it does > > . "reached" is inaccurate; "exceeded" is more accurate > > The rest of the change in wording is just to follow the style that I > frequently see in other applications in similar cases. > > The documentation parts are OK (but will need an update if you accept > the above suggestion). Actually, the wording is correct for the current implementation. The patch stops searching when the limit is reached. It doesn't keep looking for at least one more to see if there are any more. Is this absolutely critical? Why?