From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96866 invoked by alias); 25 Jul 2015 18:25:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96854 invoked by uid 89); 25 Jul 2015 18:25:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f170.google.com Received: from mail-yk0-f170.google.com (HELO mail-yk0-f170.google.com) (209.85.160.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 25 Jul 2015 18:25:52 +0000 Received: by ykdu72 with SMTP id u72so42225441ykd.2 for ; Sat, 25 Jul 2015 11:25:51 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.13.237.1 with SMTP id w1mr21565655ywe.132.1437848751038; Sat, 25 Jul 2015 11:25:51 -0700 (PDT) Received: by 10.13.233.198 with HTTP; Sat, 25 Jul 2015 11:25:50 -0700 (PDT) In-Reply-To: References: <001a11c301ba95cb5e051b62da63@google.com> Date: Sat, 25 Jul 2015 18:25:00 -0000 Message-ID: Subject: Re: [PATCH 5/8] gen-pert-test: parallel build support From: Doug Evans To: Patrick Palka Cc: Doug Evans , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00755.txt.bz2 On Sat, Jul 25, 2015 at 9:44 AM, Patrick Palka wrote: > On Tue, Jul 21, 2015 at 9:44 AM, Doug Evans wrote: >> Hi. >> >> This patch adds parallel build support for perf testcases. >> To use the existing machinery, GDB_PARALLEL now contains >> the subdirectory in which to put the parallel builds. >> >> 2015-07-20 Doug Evans >> >> * Makefile.in (check/%.exp): Pass directory for GDB_PARALLEL. >> (workers/%.worker, build-perf): New rule. >> (GDB_PERFTEST_MODE): New variable. >> (check-perf): Use it. >> (clean): Clean up gdb.perf parallel build subdirs. >> * lib/build-piece.exp: New file. >> * lib/cache.exp (gdb_do_cache): Include $GDB_PARALLEL in path name. >> * lib/gdb.exp (standard_output_file): Include $GDB_PARALLEL in path >> name. >> (standard_temp_file): Ditto. >> (GDB_PARALLEL handling): Make outputs,temp,cache directories as >> subdirs >> of $GDB_PARALLEL. > > This patch seems to have caused a number of regressions: > > http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502 > http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501 > http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1510 > > (possibly among others) > > Reverting this patch locally makes the regressions disappear for me, > at least on x86_64-m64. I can't repro this. It's odd that this patch would cause these particular regressions: http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501/steps/regressions/logs/regressions http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502/steps/regressions/logs/regressions Also, I don't understand this one: http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1420 I can imagine makefile hacking for the perf tests breaking normal make check, but then I'd expect the damage to be far more extensive, but the patch reported in 1420 cannot have caused those regressions.