From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27356 invoked by alias); 11 Dec 2014 03:06:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27345 invoked by uid 89); 11 Dec 2014 03:05:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 11 Dec 2014 03:05:56 +0000 Received: by mail-wi0-f173.google.com with SMTP id r20so13181921wiv.12 for ; Wed, 10 Dec 2014 19:05:53 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.211.108 with SMTP id nb12mr11655329wic.76.1418267152984; Wed, 10 Dec 2014 19:05:52 -0800 (PST) Received: by 10.27.132.70 with HTTP; Wed, 10 Dec 2014 19:05:52 -0800 (PST) In-Reply-To: <1418266428-13166-1-git-send-email-yao@codesourcery.com> References: <1418266428-13166-1-git-send-email-yao@codesourcery.com> Date: Thu, 11 Dec 2014 03:06:00 -0000 Message-ID: Subject: Re: [RFC] Run tests in sub dir of testsuite/ From: Doug Evans To: Yao Qi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00237.txt.bz2 On Wed, Dec 10, 2014 at 6:53 PM, Yao Qi wrote: > This patch is to run testsuite in a subdirectory of testsuite/, in > order to facilitate 'make clean'. In sequential testing, directory > testsuite/sequential-tests is created, and in parallel testing, > directory testsuite/parallel-tests is created. Testing artifacts > (such as directory gdb.base, gdb.ada, object files, shared libraries > and executables) are stored in it. > > In testsuite/Makefile.in, we set OUTPUTDIR to either sequential-tests > or parallel-tests, determined by whether we run tests in parallel. > Makefile passes OUTPUTDIR to dejagnu, and lib/gdb.exp return the > expected file path according to OUTPUTDIR. > > This patch changes the location of gdb.sum, so some build/test scripts > are affected. > > gdb/testsuite: > > 2014-12-11 Yao Qi > > * Makefile.in: Set OUTPUTDIR. > (check-single): Create dir OUTPUTDIR and pass $(OUTPUTDIR) to > runtest. > (check-parallel): Use $(OUTPUTDIR). > (check/%.exp): Pass $(OUTPUTDIR) to runtest. > (check-perf): Likewise. > (clean): Remove directory sequential-tests and parallel-tests. > * lib/gdb.exp (standard_output_file): Return file path name > according to new directory structure. > (gdb_init): Use $OUTPUTDIR instead of outputs. > (top-level): Create directory $OUTPUTDIR. > * lib/trace-support.exp (get_in_proc_agent): Don't use $objdir > in the path of inprocagent. > * gdb.base/completion.exp: Use ${OUTPUTDIR}. > * gdb.base/hashline1.exp: Use [pwd] instead of $objdir. Hi. I can't review the patch right now, but I have a question. Is there intended to be a followup patch to remove all the makefiles in testsuite/ except testsuite/Makefile.in? [I realize this patch is just RFC. I just want to understand where this is headed.] btw, while it might be cleaner to move gdb.log,gdb.sum into the subdirs, it's not necessary. I can update my build scripts, but if we're going to be affecting a lot of build scripts then I'd reconsider.