From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119198-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16265 invoked by alias); 19 Jan 2015 18:32:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16256 invoked by uid 89); 19 Jan 2015 18:32:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-we0-f176.google.com
Received: from mail-we0-f176.google.com (HELO mail-we0-f176.google.com) (74.125.82.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 19 Jan 2015 18:32:51 +0000
Received: by mail-we0-f176.google.com with SMTP id w62so6445478wes.7        for <gdb-patches@sourceware.org>; Mon, 19 Jan 2015 10:32:48 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.180.109.45 with SMTP id hp13mr37402669wib.4.1421692368607; Mon, 19 Jan 2015 10:32:48 -0800 (PST)
Received: by 10.27.39.198 with HTTP; Mon, 19 Jan 2015 10:32:48 -0800 (PST)
In-Reply-To: <83iog2y7s9.fsf@gnu.org>
References: <83zj9v7urq.fsf@gnu.org>	<CADPb22Q7oD3K-dYkngEPDBbV++mLCKifTEmvJczQ=0h2FX0yXA@mail.gmail.com>	<83sifn7mpt.fsf@gnu.org>	<CADPb22QeiSrzD81kMJeqpnDBrx1DybpbGmHc1r0koGDtqAu8tw@mail.gmail.com>	<83h9w278a9.fsf@gnu.org>	<CADPb22R_=xwonUGJMxJRtAbbK8OcSmU5ojarB=T9wjg9YEtE6Q@mail.gmail.com>	<83bnma75yt.fsf@gnu.org>	<CADPb22SvEa8-+y009ET7PQDuYixGEK6LbrJr_pyQ98SfVy_iJg@mail.gmail.com>	<837fwy74ny.fsf@gnu.org>	<CADPb22QZ8qgfYfsT=wxQg8yKRE3EzPTc8QHcHpk8oXpA6DsA2A@mail.gmail.com>	<21677.44074.982761.250152@ruffy2.mtv.corp.google.com>	<83iog2y7s9.fsf@gnu.org>
Date: Mon, 19 Jan 2015 18:32:00 -0000
Message-ID: <CAP9bCMQ82dTHdN-w8hACOYGcus6oaMNNWpAhpQtLFhT4fnbQ5w@mail.gmail.com>
Subject: Re: [PATCH] Speed up "gdb -tui" output
From: Doug Evans <xdje42@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00532.txt.bz2

On Mon, Jan 19, 2015 at 9:55 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Doug Evans <dje@google.com>
>> Date: Wed, 7 Jan 2015 13:59:06 -0800
>>
>> Doug Evans writes:
>>  > Seems like the main source of the problem would be gdb_stdout,
>>  > so let's try to fix that first and go from there.
>>
>> Here's a prototype.
>
> Sorry for a long delay.  I tried this (and Pedro's) patch today.  They
> both do the job, so one of them should IMO be committed, master and
> branch.
>
>> @@ -239,6 +243,12 @@ tui_file_flush (struct ui_file *file)
>>      case astring:
>>        break;
>>      case afile:
>> +      /* There is also gdb_stdlog, gdb_stdtarg, gdb_stdtargerr, but
>> +      tui_setup_io maps those to gdb_stderr.  OTOH, do we need to make
>> +      this conditional?  */
>> +      if (file == gdb_stdout
>> +       || file == gdb_stderr)
>> +     tui_refresh_cmd_win ();
>
> I indeed think that the condition should be removed.  I see no need
> for it: there's no reason to make any stream displayed on TUI more
> than line-buffered.

I don't have a preference on which, with one condition.
If we're going to remove the fflush's let's do it as a separate patch.