From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-121659-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15874 invoked by alias); 8 Apr 2015 01:57:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 15862 invoked by uid 89); 8 Apr 2015 01:57:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vn0-f49.google.com
Received: from mail-vn0-f49.google.com (HELO mail-vn0-f49.google.com) (209.85.216.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Apr 2015 01:57:42 +0000
Received: by vnbf1 with SMTP id f1so12018176vnb.5        for <gdb-patches@sourceware.org>; Tue, 07 Apr 2015 18:57:40 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.140.80.176 with SMTP id c45mr26500940qgd.101.1428458259933; Tue, 07 Apr 2015 18:57:39 -0700 (PDT)
Received: by 10.229.119.10 with HTTP; Tue, 7 Apr 2015 18:57:39 -0700 (PDT)
In-Reply-To: <20150407090840.GB22271@blade.nx>
References: <1427887341-31819-1-git-send-email-gbenson@redhat.com>	<1427887341-31819-6-git-send-email-gbenson@redhat.com>	<834mozsxtq.fsf@gnu.org>	<m3pp7hi44n.fsf@sspiff.org>	<83fv8djhp0.fsf@gnu.org>	<20150407090840.GB22271@blade.nx>
Date: Wed, 08 Apr 2015 01:57:00 -0000
Message-ID: <CAP9bCMQ24y4-002-my7x1PMap8f1rv2DW+BDR3BZ3LL7pMhiMw@mail.gmail.com>
Subject: Re: [PATCH 5/7] Implement remote_pid_to_exec_file using qXfer:exec-file:read
From: Doug Evans <xdje42@gmail.com>
To: Gary Benson <gbenson@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00247.txt.bz2

On Tue, Apr 7, 2015 at 2:08 AM, Gary Benson <gbenson@redhat.com> wrote:
> Eli Zaretskii wrote:
>> > From: Doug Evans <xdje42@gmail.com>
>> > Cc: Gary Benson <gbenson@redhat.com>,  gdb-patches@sourceware.org
>> > Date: Mon, 06 Apr 2015 10:00:08 -0700
>> >
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> > > > Date: Wed,  1 Apr 2015 12:22:19 +0100
>> > > >
>> > > > +qXfer:exec-file:read
>> > > > +  Return the pathname of the file that was executed to create a
>> > >             ^^^^^^^^^^^^^^^^^^^^^^^^
>> > > "the name of the file"
>> > >
>> > > OK with this change.
>> > >
>> > > > +@item qXfer:exec-file:read:@var{annex}:@var{offset},@var{length}
>> > > > +@anchor{qXfer executable filename read}
>> > > > +Return the pathname of the file that was executed to create a process
>> > >           ^^^^^^^^^^^^^^^^^^^^^^^^
>> > > Likewise.
>> > >
>> > > Otherwise, the documentation parts are OK.
>> >
>> > "the name of the file" is ambiguous though.
>> > Is it the full path name of the file? Or the base name?
>>
>> I don't know the answers, but if this is a "full path name", then
>> "the full absolute name of the file" will convey that.
>
> It should be absolute.  I will use "the full absolute name of the
> file" as Eli suggests.

Is the "full" in "full absolute name" redundant?