From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21920 invoked by alias); 9 Mar 2012 15:40:46 -0000 Received: (qmail 21906 invoked by uid 22791); 9 Mar 2012 15:40:45 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 15:40:31 +0000 Received: by pbcup15 with SMTP id up15so2837054pbc.0 for ; Fri, 09 Mar 2012 07:40:30 -0800 (PST) Received: by 10.68.195.99 with SMTP id id3mr4123251pbc.149.1331307630489; Fri, 09 Mar 2012 07:40:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.134.225 with HTTP; Fri, 9 Mar 2012 07:40:09 -0800 (PST) In-Reply-To: <20120309134014.GB2853@adacore.com> References: <20120309134014.GB2853@adacore.com> From: Josh Matthews Date: Fri, 09 Mar 2012 15:40:00 -0000 Message-ID: Subject: Re: [patch] Darwin build fix for unused prototypes To: Joel Brobecker Cc: gdb-patches@sourceware.org, Tristan Gingold Content-Type: multipart/mixed; boundary=047d7b10c8d966f0c604bad13633 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00333.txt.bz2 --047d7b10c8d966f0c604bad13633 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2244 Thanks for the suggestions. Please commit this, as I don't have access. gdb/ChangeLog: * darwin-nat-info.c (_initialize_darwin_info_commands): Add prototype. (darwin_debug_port_info): Make static. * darwin-nat.c (_initialize_darwin_inferior): Add prototype. * machoread.c (_initialize_machoread): Add prototype. * i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_get) (i386_darwin_set_control, i386_darwin_get_control) i386_darwin_dr_set_addr, i386_darwin_get_addr) i386_darwin_get_status, i386_darwin_get_control): Hide these with HW_WATCHPOINT_NOT_YET_ENABLED. Cheers, Josh On 9 March 2012 08:40, Joel Brobecker wrote: > Hi Josh, > >> 2012-03-08 =A0Josh Matthews =A0 >> >> =A0 =A0 =A0 =A0 * darwin-nat-info.c: Add missing prototype for >> _initialize_darwin_info_commands. Make darwin_debug_port_info static. >> =A0 =A0 =A0 =A0 * darwin-nat.c: Add missing prototype for _initialize_da= rwin_infereior. >> =A0 =A0 =A0 =A0 * i386-darwin-nat.c: Remove unused functions >> i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control, >> i386_darwin_get_control, i386_darwin_dr_set_addr, >> i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control. >> =A0 =A0 =A0 =A0 * machoread.c: Add missing prototype for _initialize_mac= horead. > > Before you commit, can you make sure you re-format this ChangeLog > entry so that all the text is aligned on a tab? Also, can you use > two spaces after each period. And finally, I noticed at least one > typo: > > =A0 =A0 =A0 =A0_initialize_darwin_infereior > > I suggest: > > =A0 =A0 =A0 =A0* darwin-nat-info.c (_initialize_darwin_info_commands): Add > =A0 =A0 =A0 =A0prototype. > =A0 =A0 =A0 =A0(darwin_debug_port_info): Make static. > =A0 =A0 =A0 =A0* darwin-nat.c (_initialize_darwin_inferior): Add prototyp= e. > =A0 =A0 =A0 =A0* machoread.c (_initialize_machoread): Add prototype. > =A0 =A0 =A0 =A0* i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_ge= t) > =A0 =A0 =A0 =A0(i386_darwin_set_control, i386_darwin_get_control) > =A0 =A0 =A0 =A0i386_darwin_dr_set_addr, i386_darwin_get_addr) > =A0 =A0 =A0 =A0i386_darwin_get_status, i386_darwin_get_control): > =A0 =A0 =A0 =A0Comment these functions out. > > -- > Joel --047d7b10c8d966f0c604bad13633 Content-Type: application/octet-stream; name="darwin_prototypes.diff" Content-Disposition: attachment; filename="darwin_prototypes.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gzle4cc00 Content-length: 2404 ZGlmZiAtLWdpdCBhL2dkYi9kYXJ3aW4tbmF0LWluZm8uYyBiL2dkYi9kYXJ3 aW4tbmF0LWluZm8uYwppbmRleCA5MTcwZTE0Li45NzQxNTM4IDEwMDY0NAot LS0gYS9nZGIvZGFyd2luLW5hdC1pbmZvLmMKKysrIGIvZ2RiL2Rhcndpbi1u YXQtaW5mby5jCkBAIC0zMDEsNyArMzAxLDcgQEAgaW5mb19tYWNoX3BvcnRz X2NvbW1hbmQgKGNoYXIgKmFyZ3MsIGludCBmcm9tX3R0eSkKIH0KIAogCi12 b2lkCitzdGF0aWMgdm9pZAogZGFyd2luX2RlYnVnX3BvcnRfaW5mbyAodGFz a190IHRhc2ssIG1hY2hfcG9ydF90IHBvcnQpCiB7CiAgIGtlcm5fcmV0dXJu X3Qga3JldDsKQEAgLTg0Myw2ICs4NDMsOSBAQCBpbmZvX21hY2hfZXhjZXB0 aW9uc19jb21tYW5kIChjaGFyICphcmdzLCBpbnQgZnJvbV90dHkpCiAgICAg fQogfQogCisvKiAtV21pc3NpbmctcHJvdG90eXBlcyAqLworZXh0ZXJuIGlu aXRpYWxpemVfZmlsZV9mdHlwZSBfaW5pdGlhbGl6ZV9kYXJ3aW5faW5mb19j b21tYW5kczsKKwogdm9pZAogX2luaXRpYWxpemVfZGFyd2luX2luZm9fY29t bWFuZHMgKHZvaWQpCiB7CmRpZmYgLS1naXQgYS9nZGIvZGFyd2luLW5hdC5j IGIvZ2RiL2Rhcndpbi1uYXQuYwppbmRleCAwZmVlYmUzLi5kZTY2MWEzIDEw MDY0NAotLS0gYS9nZGIvZGFyd2luLW5hdC5jCisrKyBiL2dkYi9kYXJ3aW4t bmF0LmMKQEAgLTIwMTUsNiArMjAxNSw5IEBAIGRhcndpbl9zdXBwb3J0c19t dWx0aV9wcm9jZXNzICh2b2lkKQogICByZXR1cm4gMTsKIH0KIAorLyogLVdt aXNzaW5nLXByb3RvdHlwZXMgKi8KK2V4dGVybiBpbml0aWFsaXplX2ZpbGVf ZnR5cGUgX2luaXRpYWxpemVfZGFyd2luX2luZmVyaW9yOworCiB2b2lkCiBf aW5pdGlhbGl6ZV9kYXJ3aW5faW5mZXJpb3IgKHZvaWQpCiB7CmRpZmYgLS1n aXQgYS9nZGIvaTM4Ni1kYXJ3aW4tbmF0LmMgYi9nZGIvaTM4Ni1kYXJ3aW4t bmF0LmMKaW5kZXggYjQ1MmYxZS4uY2VkMjkwMyAxMDA2NDQKLS0tIGEvZ2Ri L2kzODYtZGFyd2luLW5hdC5jCisrKyBiL2dkYi9pMzg2LWRhcndpbi1uYXQu YwpAQCAtMjYwLDcgKzI2MCw3IEBAIGkzODZfZGFyd2luX3N0b3JlX2luZmVy aW9yX3JlZ2lzdGVycyAoc3RydWN0IHRhcmdldF9vcHMgKm9wcywKICAgICB9 CiB9CiAKLQorI2lmZGVmIEhXX1dBVENIUE9JTlRfTk9UX1lFVF9FTkFCTEVE CiAvKiBTdXBwb3J0IGZvciBkZWJ1ZyByZWdpc3RlcnMsIGJvb3N0ZWQgbW9z dGx5IGZyb20gaTM4Ni1saW51eC1uYXQuYy4gICovCiAKIHN0YXRpYyB2b2lk CkBAIC00MTAsNiArNDEwLDcgQEAgaTM4Nl9kYXJ3aW5fZHJfZ2V0X2NvbnRy b2wgKHZvaWQpCiB7CiAgIHJldHVybiBpMzg2X2Rhcndpbl9kcl9nZXQgKERS X0NPTlRST0wpOwogfQorI2VuZGlmCiAKIHZvaWQKIGRhcndpbl9jaGVja19v c2FiaSAoZGFyd2luX2luZmVyaW9yICppbmYsIHRocmVhZF90IHRocmVhZCkK ZGlmZiAtLWdpdCBhL2dkYi9tYWNob3JlYWQuYyBiL2dkYi9tYWNob3JlYWQu YwppbmRleCA4OGNlNjEyLi44YTZiNTAwIDEwMDY0NAotLS0gYS9nZGIvbWFj aG9yZWFkLmMKKysrIGIvZ2RiL21hY2hvcmVhZC5jCkBAIC0xMDM1LDYgKzEw MzUsOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHN5bV9mbnMgbWFjaG9fc3lt X2ZucyA9IHsKICAgJnBzeW1fZnVuY3Rpb25zCiB9OwogCisvKiAtV21pc3Np bmctcHJvdG90eXBlcyAqLworZXh0ZXJuIGluaXRpYWxpemVfZmlsZV9mdHlw ZSBfaW5pdGlhbGl6ZV9tYWNob3JlYWQ7CisKIHZvaWQKIF9pbml0aWFsaXpl X21hY2hvcmVhZCAoKQogewo= --047d7b10c8d966f0c604bad13633--