From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32153 invoked by alias); 9 Mar 2012 17:22:04 -0000 Received: (qmail 32134 invoked by uid 22791); 9 Mar 2012 17:22:01 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_FN X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 17:21:47 +0000 Received: by pbcup15 with SMTP id up15so2927739pbc.0 for ; Fri, 09 Mar 2012 09:21:47 -0800 (PST) Received: by 10.68.195.99 with SMTP id id3mr4616010pbc.149.1331313707295; Fri, 09 Mar 2012 09:21:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.134.225 with HTTP; Fri, 9 Mar 2012 09:21:27 -0800 (PST) In-Reply-To: <20120309163451.GC2853@adacore.com> References: <20120309134014.GB2853@adacore.com> <20120309163451.GC2853@adacore.com> From: Josh Matthews Date: Fri, 09 Mar 2012 17:22:00 -0000 Message-ID: Subject: Re: [patch] Darwin build fix for unused prototypes To: Joel Brobecker Cc: gdb-patches@sourceware.org, Tristan Gingold Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00342.txt.bz2 I lost the copyright assignment form and haven't been able to find it, unfortunately. Since I'm now able to print it and send it myself, I'll do that, but I don't think it's worth holding up this change for the form. I have aspirations of fixing the problem that prevents gdb from being able to debug Firefox, but that's been fruitless for me so far. Cheers, Josh On 9 March 2012 11:34, Joel Brobecker wrote: > Hi Josh > >> Thanks for the suggestions. Please commit this, as I don't have access. > > Do you have a copyright assignment on file with FSF. I searched the > records, and could not find you... > > If not, we can acceptthis patch as a "tiny change" (which is also > obvious). But if you think that you might make more contributions > in the future, it would be better if you had one. =A0Otherwise, the > total volume of your contributions would exceed our guidelins for > max contribution size without copyright assignment. > > Thanks, > -- > Joel > >> gdb/ChangeLog: >> >> =A0 =A0 =A0 * darwin-nat-info.c (_initialize_darwin_info_commands): Add >> =A0 =A0 =A0 prototype. >> =A0 =A0 =A0 (darwin_debug_port_info): Make static. >> =A0 =A0 =A0 * darwin-nat.c (_initialize_darwin_inferior): Add prototype. >> =A0 =A0 =A0 * machoread.c (_initialize_machoread): Add prototype. >> =A0 =A0 =A0 * i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr_get) >> =A0 =A0 =A0 (i386_darwin_set_control, i386_darwin_get_control) >> =A0 =A0 =A0 i386_darwin_dr_set_addr, i386_darwin_get_addr) >> =A0 =A0 =A0 i386_darwin_get_status, i386_darwin_get_control): >> =A0 =A0 =A0 Hide these with HW_WATCHPOINT_NOT_YET_ENABLED. >> >> Cheers, >> Josh >> >> On 9 March 2012 08:40, Joel Brobecker wrote: >> > Hi Josh, >> > >> >> 2012-03-08 =A0Josh Matthews =A0 >> >> >> >> =A0 =A0 =A0 =A0 * darwin-nat-info.c: Add missing prototype for >> >> _initialize_darwin_info_commands. Make darwin_debug_port_info static. >> >> =A0 =A0 =A0 =A0 * darwin-nat.c: Add missing prototype for _initialize= _darwin_infereior. >> >> =A0 =A0 =A0 =A0 * i386-darwin-nat.c: Remove unused functions >> >> i386_darwin_dr_set, i386_darwin_dr_get, i386_darwin_set_control, >> >> i386_darwin_get_control, i386_darwin_dr_set_addr, >> >> i386_darwin_get_addr, i386_darwin_get_status, i386_darwin_get_control. >> >> =A0 =A0 =A0 =A0 * machoread.c: Add missing prototype for _initialize_= machoread. >> > >> > Before you commit, can you make sure you re-format this ChangeLog >> > entry so that all the text is aligned on a tab? Also, can you use >> > two spaces after each period. And finally, I noticed at least one >> > typo: >> > >> > =A0 =A0 =A0 =A0_initialize_darwin_infereior >> > >> > I suggest: >> > >> > =A0 =A0 =A0 =A0* darwin-nat-info.c (_initialize_darwin_info_commands):= Add >> > =A0 =A0 =A0 =A0prototype. >> > =A0 =A0 =A0 =A0(darwin_debug_port_info): Make static. >> > =A0 =A0 =A0 =A0* darwin-nat.c (_initialize_darwin_inferior): Add proto= type. >> > =A0 =A0 =A0 =A0* machoread.c (_initialize_machoread): Add prototype. >> > =A0 =A0 =A0 =A0* i386-darwin-nat.c (i386_darwin_dr_set, i386_darwin_dr= _get) >> > =A0 =A0 =A0 =A0(i386_darwin_set_control, i386_darwin_get_control) >> > =A0 =A0 =A0 =A0i386_darwin_dr_set_addr, i386_darwin_get_addr) >> > =A0 =A0 =A0 =A0i386_darwin_get_status, i386_darwin_get_control): >> > =A0 =A0 =A0 =A0Comment these functions out. >> > >> > -- >> > Joel > >> diff --git a/gdb/darwin-nat-info.c b/gdb/darwin-nat-info.c >> index 9170e14..9741538 100644 >> --- a/gdb/darwin-nat-info.c >> +++ b/gdb/darwin-nat-info.c >> @@ -301,7 +301,7 @@ info_mach_ports_command (char *args, int from_tty) >> =A0} >> >> >> -void >> +static void >> =A0darwin_debug_port_info (task_t task, mach_port_t port) >> =A0{ >> =A0 =A0kern_return_t kret; >> @@ -843,6 +843,9 @@ info_mach_exceptions_command (char *args, int from_t= ty) >> =A0 =A0 =A0} >> =A0} >> >> +/* -Wmissing-prototypes */ >> +extern initialize_file_ftype _initialize_darwin_info_commands; >> + >> =A0void >> =A0_initialize_darwin_info_commands (void) >> =A0{ >> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c >> index 0feebe3..de661a3 100644 >> --- a/gdb/darwin-nat.c >> +++ b/gdb/darwin-nat.c >> @@ -2015,6 +2015,9 @@ darwin_supports_multi_process (void) >> =A0 =A0return 1; >> =A0} >> >> +/* -Wmissing-prototypes */ >> +extern initialize_file_ftype _initialize_darwin_inferior; >> + >> =A0void >> =A0_initialize_darwin_inferior (void) >> =A0{ >> diff --git a/gdb/i386-darwin-nat.c b/gdb/i386-darwin-nat.c >> index b452f1e..ced2903 100644 >> --- a/gdb/i386-darwin-nat.c >> +++ b/gdb/i386-darwin-nat.c >> @@ -260,7 +260,7 @@ i386_darwin_store_inferior_registers (struct target_= ops *ops, >> =A0 =A0 =A0} >> =A0} >> >> - >> +#ifdef HW_WATCHPOINT_NOT_YET_ENABLED >> =A0/* Support for debug registers, boosted mostly from i386-linux-nat.c.= =A0*/ >> >> =A0static void >> @@ -410,6 +410,7 @@ i386_darwin_dr_get_control (void) >> =A0{ >> =A0 =A0return i386_darwin_dr_get (DR_CONTROL); >> =A0} >> +#endif >> >> =A0void >> =A0darwin_check_osabi (darwin_inferior *inf, thread_t thread) >> diff --git a/gdb/machoread.c b/gdb/machoread.c >> index 88ce612..8a6b500 100644 >> --- a/gdb/machoread.c >> +++ b/gdb/machoread.c >> @@ -1035,6 +1035,9 @@ static const struct sym_fns macho_sym_fns =3D { >> =A0 =A0&psym_functions >> =A0}; >> >> +/* -Wmissing-prototypes */ >> +extern initialize_file_ftype _initialize_machoread; >> + >> =A0void >> =A0_initialize_machoread () >> =A0{ > > > -- > Joel