Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Bob Steagall <bob.steagall.cpp@gmail.com>
To: gdb-patches@sourceware.org
Subject: Re: potential patch for gdb bug c++/20020 - updated
Date: Fri, 07 Dec 2018 12:57:00 -0000	[thread overview]
Message-ID: <CAOhs8xJN5+z3NBqHnf3KXRcdO=7efZqdA4xueoeAdV2fDJLDJg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

Description:

This patch, against released version 8.2, fixes the
problem reported in gdb bug c++/20020, using the
approach described in comment 1 of that report.

Changelog entry:

2018-12-06  Bob Steagall   <bob.steagall.cpp@gmail.com>

        * cp-valprint.c: Fixes bug c++/20020.

[-- Attachment #2: fix-for-20020.patch --]
[-- Type: text/x-patch, Size: 615 bytes --]

--- gdb/cp-valprint.c	2018-09-05 03:27:13.000000000 -0400
+++ gdb/cp-valprint.c.new	2018-12-07 07:41:00.657110092 -0500
@@ -329,9 +329,10 @@ cp_print_value_fields (struct type *type
 		    }
 		  END_CATCH
 
-		  cp_print_static_field (TYPE_FIELD_TYPE (type, i),
-					 v, stream, recurse + 1,
-					 options);
+                  if (v != NULL)
+                      cp_print_static_field (TYPE_FIELD_TYPE (type, i),
+                                             v, stream, recurse + 1,
+                                             options);
 		}
 	      else if (i == vptr_fieldno && type == vptr_basetype)
 		{

             reply	other threads:[~2018-12-07 12:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 12:57 Bob Steagall [this message]
2018-12-07 15:49 ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOhs8xJN5+z3NBqHnf3KXRcdO=7efZqdA4xueoeAdV2fDJLDJg@mail.gmail.com' \
    --to=bob.steagall.cpp@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox