From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1865 invoked by alias); 14 Sep 2011 05:04:46 -0000 Received: (qmail 1856 invoked by uid 22791); 14 Sep 2011 05:04:44 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Sep 2011 05:04:28 +0000 Received: by wwf27 with SMTP id 27so1338278wwf.12 for ; Tue, 13 Sep 2011 22:04:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.132.129 with SMTP id o1mr1915719wei.3.1315976665074; Tue, 13 Sep 2011 22:04:25 -0700 (PDT) Received: by 10.216.159.205 with HTTP; Tue, 13 Sep 2011 22:04:24 -0700 (PDT) In-Reply-To: <20110913215311.GA20018@host1.jankratochvil.net> References: <201109121623.04292.pedro@codesourcery.com> <20110913092440.GA12661@host1.jankratochvil.net> <20110913215311.GA20018@host1.jankratochvil.net> Date: Wed, 14 Sep 2011 06:32:00 -0000 Message-ID: Subject: Re: Some code-cleanup From: Abhijit Halder To: Jan Kratochvil Cc: Pedro Alves , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e6de03a4a78df004acdfb1b2 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00242.txt.bz2 --0016e6de03a4a78df004acdfb1b2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 3009 On Wed, Sep 14, 2011 at 3:23 AM, Jan Kratochvil wrote: > On Tue, 13 Sep 2011 14:20:15 +0200, Abhijit Halder wrote: >> --- gdb/parse.c =A0 =A0 =A0 17 Jun 2011 20:24:22 -0000 =A0 =A0 =A01.110 >> +++ gdb/parse.c =A0 =A0 =A0 13 Sep 2011 12:09:19 -0000 >> @@ -23,7 +23,7 @@ >> =A0 =A0 along with this program. =A0If not, see . =A0*/ >> >> =A0/* Parse an expression from text in a string, >> - =A0 and return the result as a =A0struct expression =A0pointer. >> + =A0 and return the result as a struct expression pointer. >> =A0 =A0 That structure contains arithmetic operations in reverse polish, >> =A0 =A0 with constants represented by operations that are followed by sp= ecial data. >> =A0 =A0 See expression.h for the details of the format. > > This change is missing in the FSF changeLog. =A0(sorry but it is AFAIK a = FSF > policy) > > >> @@ -190,7 +190,7 @@ free_funcalls (void *ignore) >> =A0 =A0 =A0} >> =A0} >> >> -/* This page contains the functions for adding data to the =A0struct ex= pression >> +/* This page contains the functions for adding data to the struct expre= ssion >> =A0 =A0 being constructed. =A0*/ >> >> =A0/* Add one element to the end of the expression. =A0*/ > > This change is missing in the FSF changeLog. > > >> @@ -199,7 +199,7 @@ free_funcalls (void *ignore) >> =A0 =A0 a register through here. =A0*/ >> >> =A0void >> -write_exp_elt (union exp_element expelt) >> +write_exp_elt (const union exp_element *expelt) >> =A0{ >> =A0 =A0if (expout_ptr >=3D expout_size) >> =A0 =A0 =A0{ > > This function should be made `static' as I wrote before. > > >> @@ -1059,7 +1059,7 @@ prefixify_subexp (struct expression *ine >> =A0} >> >> =A0/* Read an expression from the string *STRINGPTR points to, >> - =A0 parse it, and return a pointer to a =A0struct expression =A0that w= e malloc. >> + =A0 parse it, and return a pointer to a struct expression that we mall= oc. >> =A0 =A0 Use block BLOCK as the lexical context for variable names; >> =A0 =A0 if BLOCK is zero, use the block of the selected stack frame. >> =A0 =A0 Meanwhile, advance *STRINGPTR to point after the expression, > > This change is missing in the FSF changeLog. > > >> --- gdb/parser-defs.h 10 Jan 2011 20:38:49 -0000 =A0 =A0 =A01.39 >> +++ gdb/parser-defs.h 13 Sep 2011 12:09:19 -0000 >> @@ -131,7 +131,7 @@ union type_stack_elt >> =A0extern union type_stack_elt *type_stack; >> =A0extern int type_stack_depth, type_stack_size; >> >> -extern void write_exp_elt (union exp_element); >> +extern void write_exp_elt (const union exp_element *); >> >> =A0extern void write_exp_elt_opcode (enum exp_opcode); >> > > This declaration line should be removed completely as I wrote before. > write_exp_elt is not called from any other file so I find updating > a declaration which has no use anyway does not make much sense. > > OK with these changes, if you follow the changes. > > > Thanks, > Jan > Corrected the same. Please review the changes. Thanks, Abhijit Halder --0016e6de03a4a78df004acdfb1b2 Content-Type: text/x-patch; charset=US-ASCII; name="code-cleanup.patch" Content-Disposition: attachment; filename="code-cleanup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gsjuesoi0 Content-length: 6088 SW5kZXg6IGdkYi9wYXJzZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvcGFyc2UuYyx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS4xMTAKZGlmZiAtdSAtcCAtcjEuMTEwIHBhcnNlLmMKLS0t IGdkYi9wYXJzZS5jCTE3IEp1biAyMDExIDIwOjI0OjIyIC0wMDAwCTEuMTEw CisrKyBnZGIvcGFyc2UuYwkxNCBTZXAgMjAxMSAwNDozOToxNiAtMDAwMApA QCAtMjMsNyArMjMsNyBAQAogICAgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0u ICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4u ICAqLwogCiAvKiBQYXJzZSBhbiBleHByZXNzaW9uIGZyb20gdGV4dCBpbiBh IHN0cmluZywKLSAgIGFuZCByZXR1cm4gdGhlIHJlc3VsdCBhcyBhICBzdHJ1 Y3QgZXhwcmVzc2lvbiAgcG9pbnRlci4KKyAgIGFuZCByZXR1cm4gdGhlIHJl c3VsdCBhcyBhIHN0cnVjdCBleHByZXNzaW9uIHBvaW50ZXIuCiAgICBUaGF0 IHN0cnVjdHVyZSBjb250YWlucyBhcml0aG1ldGljIG9wZXJhdGlvbnMgaW4g cmV2ZXJzZSBwb2xpc2gsCiAgICB3aXRoIGNvbnN0YW50cyByZXByZXNlbnRl ZCBieSBvcGVyYXRpb25zIHRoYXQgYXJlIGZvbGxvd2VkIGJ5IHNwZWNpYWwg ZGF0YS4KICAgIFNlZSBleHByZXNzaW9uLmggZm9yIHRoZSBkZXRhaWxzIG9m IHRoZSBmb3JtYXQuCkBAIC0xOTAsNyArMTkwLDcgQEAgZnJlZV9mdW5jYWxs cyAodm9pZCAqaWdub3JlKQogICAgIH0KIH0KIAwKLS8qIFRoaXMgcGFnZSBj b250YWlucyB0aGUgZnVuY3Rpb25zIGZvciBhZGRpbmcgZGF0YSB0byB0aGUg IHN0cnVjdCBleHByZXNzaW9uCisvKiBUaGlzIHBhZ2UgY29udGFpbnMgdGhl IGZ1bmN0aW9ucyBmb3IgYWRkaW5nIGRhdGEgdG8gdGhlIHN0cnVjdCBleHBy ZXNzaW9uCiAgICBiZWluZyBjb25zdHJ1Y3RlZC4gICovCiAKIC8qIEFkZCBv bmUgZWxlbWVudCB0byB0aGUgZW5kIG9mIHRoZSBleHByZXNzaW9uLiAgKi8K QEAgLTE5OCw4ICsxOTgsOCBAQCBmcmVlX2Z1bmNhbGxzICh2b2lkICppZ25v cmUpCiAvKiBUbyBhdm9pZCBhIGJ1ZyBpbiB0aGUgU3VuIDQgY29tcGlsZXIs IHdlIHBhc3MgdGhpbmdzIHRoYXQgY2FuIGZpdCBpbnRvCiAgICBhIHJlZ2lz dGVyIHRocm91Z2ggaGVyZS4gICovCiAKLXZvaWQKLXdyaXRlX2V4cF9lbHQg KHVuaW9uIGV4cF9lbGVtZW50IGV4cGVsdCkKK3N0YXRpYyB2b2lkCit3cml0 ZV9leHBfZWx0IChjb25zdCB1bmlvbiBleHBfZWxlbWVudCAqZXhwZWx0KQog ewogICBpZiAoZXhwb3V0X3B0ciA+PSBleHBvdXRfc2l6ZSkKICAgICB7CkBA IC0yMDgsNyArMjA4LDcgQEAgd3JpdGVfZXhwX2VsdCAodW5pb24gZXhwX2Vs ZW1lbnQgZXhwZWx0KQogCXhyZWFsbG9jICgoY2hhciAqKSBleHBvdXQsIHNp emVvZiAoc3RydWN0IGV4cHJlc3Npb24pCiAJCSAgKyBFWFBfRUxFTV9UT19C WVRFUyAoZXhwb3V0X3NpemUpKTsKICAgICB9Ci0gIGV4cG91dC0+ZWx0c1tl eHBvdXRfcHRyKytdID0gZXhwZWx0OworICBleHBvdXQtPmVsdHNbZXhwb3V0 X3B0cisrXSA9ICpleHBlbHQ7CiB9CiAKIHZvaWQKQEAgLTIxOCw3ICsyMTgs NyBAQCB3cml0ZV9leHBfZWx0X29wY29kZSAoZW51bSBleHBfb3Bjb2RlIGV4 CiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9uIGV4cF9lbGVt ZW50KSk7CiAgIHRtcC5vcGNvZGUgPSBleHBlbHQ7Ci0gIHdyaXRlX2V4cF9l bHQgKHRtcCk7CisgIHdyaXRlX2V4cF9lbHQgKCZ0bXApOwogfQogCiB2b2lk CkBAIC0yMjgsNyArMjI4LDcgQEAgd3JpdGVfZXhwX2VsdF9zeW0gKHN0cnVj dCBzeW1ib2wgKmV4cGVsdAogCiAgIG1lbXNldCAoJnRtcCwgMCwgc2l6ZW9m ICh1bmlvbiBleHBfZWxlbWVudCkpOwogICB0bXAuc3ltYm9sID0gZXhwZWx0 OwotICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3cml0ZV9leHBfZWx0ICgm dG1wKTsKIH0KIAogdm9pZApAQCAtMjM4LDcgKzIzOCw3IEBAIHdyaXRlX2V4 cF9lbHRfYmxvY2sgKHN0cnVjdCBibG9jayAqYikKIAogICBtZW1zZXQgKCZ0 bXAsIDAsIHNpemVvZiAodW5pb24gZXhwX2VsZW1lbnQpKTsKICAgdG1wLmJs b2NrID0gYjsKLSAgd3JpdGVfZXhwX2VsdCAodG1wKTsKKyAgd3JpdGVfZXhw X2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI0OCw3ICsyNDgsNyBAQCB3 cml0ZV9leHBfZWx0X29iamZpbGUgKHN0cnVjdCBvYmpmaWxlICpvCiAKICAg bWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9uIGV4cF9lbGVtZW50KSk7 CiAgIHRtcC5vYmpmaWxlID0gb2JqZmlsZTsKLSAgd3JpdGVfZXhwX2VsdCAo dG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQKQEAg LTI1OCw3ICsyNTgsNyBAQCB3cml0ZV9leHBfZWx0X2xvbmdjc3QgKExPTkdF U1QgZXhwZWx0KQogCiAgIG1lbXNldCAoJnRtcCwgMCwgc2l6ZW9mICh1bmlv biBleHBfZWxlbWVudCkpOwogICB0bXAubG9uZ2NvbnN0ID0gZXhwZWx0Owot ICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3cml0ZV9leHBfZWx0ICgmdG1w KTsKIH0KIAogdm9pZApAQCAtMjY4LDcgKzI2OCw3IEBAIHdyaXRlX2V4cF9l bHRfZGJsY3N0IChET1VCTEVTVCBleHBlbHQpCiAKICAgbWVtc2V0ICgmdG1w LCAwLCBzaXplb2YgKHVuaW9uIGV4cF9lbGVtZW50KSk7CiAgIHRtcC5kb3Vi bGVjb25zdCA9IGV4cGVsdDsKLSAgd3JpdGVfZXhwX2VsdCAodG1wKTsKKyAg d3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI4MCw3ICsy ODAsNyBAQCB3cml0ZV9leHBfZWx0X2RlY2Zsb2F0Y3N0IChnZGJfYnl0ZSBl eHBlCiAgIGZvciAoaW5kZXggPSAwOyBpbmRleCA8IDE2OyBpbmRleCsrKQog ICAgIHRtcC5kZWNmbG9hdGNvbnN0W2luZGV4XSA9IGV4cGVsdFtpbmRleF07 CiAKLSAgd3JpdGVfZXhwX2VsdCAodG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAo JnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI5MCw3ICsyOTAsNyBAQCB3cml0ZV9l eHBfZWx0X3R5cGUgKHN0cnVjdCB0eXBlICpleHBlbHQpCiAKICAgbWVtc2V0 ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9uIGV4cF9lbGVtZW50KSk7CiAgIHRt cC50eXBlID0gZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3 cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogdm9pZApAQCAtMzAwLDcgKzMw MCw3IEBAIHdyaXRlX2V4cF9lbHRfaW50ZXJuIChzdHJ1Y3QgaW50ZXJuYWx2 YXIKIAogICBtZW1zZXQgKCZ0bXAsIDAsIHNpemVvZiAodW5pb24gZXhwX2Vs ZW1lbnQpKTsKICAgdG1wLmludGVybmFsdmFyID0gZXhwZWx0OwotICB3cml0 ZV9leHBfZWx0ICh0bXApOworICB3cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0K IAogLyogQWRkIGEgc3RyaW5nIGNvbnN0YW50IHRvIHRoZSBlbmQgb2YgdGhl IGV4cHJlc3Npb24uCkBAIC0xMDU5LDcgKzEwNTksNyBAQCBwcmVmaXhpZnlf c3ViZXhwIChzdHJ1Y3QgZXhwcmVzc2lvbiAqaW5lCiB9CiAMCiAvKiBSZWFk IGFuIGV4cHJlc3Npb24gZnJvbSB0aGUgc3RyaW5nICpTVFJJTkdQVFIgcG9p bnRzIHRvLAotICAgcGFyc2UgaXQsIGFuZCByZXR1cm4gYSBwb2ludGVyIHRv IGEgIHN0cnVjdCBleHByZXNzaW9uICB0aGF0IHdlIG1hbGxvYy4KKyAgIHBh cnNlIGl0LCBhbmQgcmV0dXJuIGEgcG9pbnRlciB0byBhIHN0cnVjdCBleHBy ZXNzaW9uIHRoYXQgd2UgbWFsbG9jLgogICAgVXNlIGJsb2NrIEJMT0NLIGFz IHRoZSBsZXhpY2FsIGNvbnRleHQgZm9yIHZhcmlhYmxlIG5hbWVzOwogICAg aWYgQkxPQ0sgaXMgemVybywgdXNlIHRoZSBibG9jayBvZiB0aGUgc2VsZWN0 ZWQgc3RhY2sgZnJhbWUuCiAgICBNZWFud2hpbGUsIGFkdmFuY2UgKlNUUklO R1BUUiB0byBwb2ludCBhZnRlciB0aGUgZXhwcmVzc2lvbiwKSW5kZXg6IGdk Yi9wYXJzZXItZGVmcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvc3JjL3NyYy9nZGIvcGFyc2VyLWRlZnMuaCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4zOQpkaWZmIC11IC1wIC1yMS4zOSBwYXJzZXItZGVm cy5oCi0tLSBnZGIvcGFyc2VyLWRlZnMuaAkxMCBKYW4gMjAxMSAyMDozODo0 OSAtMDAwMAkxLjM5CisrKyBnZGIvcGFyc2VyLWRlZnMuaAkxNCBTZXAgMjAx MSAwNDozOToxNiAtMDAwMApAQCAtMTMxLDggKzEzMSw2IEBAIHVuaW9uIHR5 cGVfc3RhY2tfZWx0CiBleHRlcm4gdW5pb24gdHlwZV9zdGFja19lbHQgKnR5 cGVfc3RhY2s7CiBleHRlcm4gaW50IHR5cGVfc3RhY2tfZGVwdGgsIHR5cGVf c3RhY2tfc2l6ZTsKIAotZXh0ZXJuIHZvaWQgd3JpdGVfZXhwX2VsdCAodW5p b24gZXhwX2VsZW1lbnQpOwotCiBleHRlcm4gdm9pZCB3cml0ZV9leHBfZWx0 X29wY29kZSAoZW51bSBleHBfb3Bjb2RlKTsKIAogZXh0ZXJuIHZvaWQgd3Jp dGVfZXhwX2VsdF9zeW0gKHN0cnVjdCBzeW1ib2wgKik7Cg== --0016e6de03a4a78df004acdfb1b2 Content-Type: application/octet-stream; name=ChangeLog Content-Disposition: attachment; filename=ChangeLog Content-Transfer-Encoding: base64 X-Attachment-Id: f_gsjufr6b1 Content-length: 773 MjAxMS0wOS0xMyAgQWJoaWppdCBIYWxkZXIgIDxhYmhpaml0LmsuaGFsZGVy QGdtYWlsLmNvbT4KCglDb2RlIGNsZWFudXAuCgkqIHBhcnNlLmMgKHdyaXRl X2V4cF9lbHQpOiBDaGFuZ2UgYXJndW1lbnQgdG8gcGFzcyBhIHBvaW50ZXIg b2YgdW5pb24KCWBleHBfZWxlbWVudCcgaW5zdGVhZCBvZiBhbiBlbGVtZW50 IG9mIHRoZSBzYW1lIGFuZCBtYWtlIHRoZSBmdW5jdGlvbgoJc3RhdGljLgoJ KHdyaXRlX2V4cF9lbHRfb3Bjb2RlLCB3cml0ZV9leHBfZWx0X3N5bSwgd3Jp dGVfZXhwX2VsdF9ibG9jaykKCSh3cml0ZV9leHBfZWx0X29iamZpbGUsIHdy aXRlX2V4cF9lbHRfbG9uZ2NzdCwgd3JpdGVfZXhwX2VsdF9kYmxjc3QpCgko d3JpdGVfZXhwX2VsdF9kZWNmbG9hdGNzdCwgd3JpdGVfZXhwX2VsdF90eXBl LCB3cml0ZV9leHBfZWx0X2ludGVybik6CglDaGFuZ2UgYXJndW1lbnQgb2Yg YHdyaXRlX2V4cF9lbHQnIGZ1bmN0aW9uIGNhbGwuCglSZW1vdmUgZXh0cmEg c3BhY2VzIGZyb20gY29tbWVudHMuCgkqIHBhcnNlci1kZWZzLmggKHdyaXRl X2V4cF9lbHQpOiBSZW1vdmUgcHJvdG90eXBlLgo= --0016e6de03a4a78df004acdfb1b2--