From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18086 invoked by alias); 25 Sep 2011 08:51:16 -0000 Received: (qmail 18076 invoked by uid 22791); 25 Sep 2011 08:51:15 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-yi0-f41.google.com (HELO mail-yi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 25 Sep 2011 08:51:01 +0000 Received: by yia25 with SMTP id 25so4282131yia.0 for ; Sun, 25 Sep 2011 01:51:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.29.228 with SMTP id n4mr21761028pbh.64.1316940660271; Sun, 25 Sep 2011 01:51:00 -0700 (PDT) Received: by 10.143.147.12 with HTTP; Sun, 25 Sep 2011 01:51:00 -0700 (PDT) Date: Sun, 25 Sep 2011 10:18:00 -0000 Message-ID: Subject: [PATCH] PR-10034 Bad space handling in set remote exec-file command From: Abhijit Halder To: "gdb-patches@sourceware.org ml" Content-Type: multipart/mixed; boundary=bcaec520ee773ee91404adc024d8 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00439.txt.bz2 --bcaec520ee773ee91404adc024d8 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 710 Hi, In the set remote exec-file command if we provide space at the end of the file-name the space is not being cleared. This behaviour is inconsistent across similar set commands like set logging file etc. My patch will fix that behaviour. Please review this patch. Further, I have found that there is a function in cli/cli-utils.c called remove_trailing_whitespace that never used. In many times we have removed trailing spaces and for that inline code is written. In my next patch I am planning to modify the remove_trailing_whitespace function and use it whenever possible in that. Since that patch will be relevant to current fix I am proposing, I have mentioned here that point. Thanks, Abhijit Halder --bcaec520ee773ee91404adc024d8 Content-Type: text/plain; charset=US-ASCII; name="ChangeLog.txt" Content-Disposition: attachment; filename="ChangeLog.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gszsavf40 Content-length: 249 MjAxMS0wOS0xMyAgQWJoaWppdCBIYWxkZXIgIDxhYmhpaml0LmsuaGFsZGVy QGdtYWlsLmNvbT4KCglGaXggUFIgcmVtb3RlLzEwMDM0OgoJKiBjbGkvY2xp LXNldHNob3cuYyAoZG9fc2V0c2hvd19jb21tYW5kKTogQ2xlYXIgdHJhaWxp bmcgd2hpdGVzcGFjZQoJZnJvbSBjb21tYW5kIGFyZ3VtZW50IHN0cmluZ3Mu Cg== --bcaec520ee773ee91404adc024d8 Content-Type: text/x-patch; charset=US-ASCII; name="gdb-space-issue.patch" Content-Disposition: attachment; filename="gdb-space-issue.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gszsb1cy1 Content-length: 1582 SW5kZXg6IGdkYi9jbGkvY2xpLXNldHNob3cuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2NsaS9jbGktc2V0 c2hvdy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQ2CmRpZmYgLWEgLXAg LXUgLXIxLjQ2IGNsaS1zZXRzaG93LmMKLS0tIGdkYi9jbGkvY2xpLXNldHNo b3cuYwk0IEF1ZyAyMDExIDE5OjEwOjEzIC0wMDAwCTEuNDYKKysrIGdkYi9j bGkvY2xpLXNldHNob3cuYwkyNSBTZXAgMjAxMSAwODoyODo1MiAtMDAwMApA QCAtMTgxLDYgKzE4MSwxNCBAQCBkb19zZXRzaG93X2NvbW1hbmQgKGNoYXIg KmFyZywgaW50IGZyb21fCiAJICAgIGFyZyA9ICIiOwogCSAgaWYgKCooY2hh ciAqKikgYy0+dmFyICE9IE5VTEwpCiAJICAgIHhmcmVlICgqKGNoYXIgKiop IGMtPnZhcik7CisJICB7CisJICAgIC8qIENsZWFyIHRyYWlsaW5nIHdoaXRl c3BhY2Ugb2Ygc3RyaW5nLiAgKi8KKwkgICAgY2hhciAqcHRyID0gYXJnICsg c3RybGVuIChhcmcpIC0gMTsKKworCSAgICB3aGlsZSAocHRyID49IGFyZyAm JiAoKnB0ciA9PSAnICcgfHwgKnB0ciA9PSAnXHQnKSkKKwkgICAgICBwdHIt LTsKKwkgICAgKihwdHIgKyAxKSA9ICdcMCc7CisJICB9CiAJICAqKGNoYXIg KiopIGMtPnZhciA9IHhzdHJkdXAgKGFyZyk7CiAJICBicmVhazsKIAljYXNl IHZhcl9vcHRpb25hbF9maWxlbmFtZToKQEAgLTE4OCw2ICsxOTYsMTQgQEAg ZG9fc2V0c2hvd19jb21tYW5kIChjaGFyICphcmcsIGludCBmcm9tXwogCSAg ICBhcmcgPSAiIjsKIAkgIGlmICgqKGNoYXIgKiopIGMtPnZhciAhPSBOVUxM KQogCSAgICB4ZnJlZSAoKihjaGFyICoqKSBjLT52YXIpOworCSAgeworCSAg ICAvKiBDbGVhciB0cmFpbGluZyB3aGl0ZXNwYWNlIG9mIGZpbGVuYW1lLiAg Ki8KKwkgICAgY2hhciAqcHRyID0gYXJnICsgc3RybGVuIChhcmcpIC0gMTsK KworCSAgICB3aGlsZSAocHRyID49IGFyZyAmJiAoKnB0ciA9PSAnICcgfHwg KnB0ciA9PSAnXHQnKSkKKwkgICAgICBwdHItLTsKKwkgICAgKihwdHIgKyAx KSA9ICdcMCc7CisJICB9CiAJICAqKGNoYXIgKiopIGMtPnZhciA9IHhzdHJk dXAgKGFyZyk7CiAJICBicmVhazsKIAljYXNlIHZhcl9maWxlbmFtZToK --bcaec520ee773ee91404adc024d8--