From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31214 invoked by alias); 29 Sep 2011 11:25:38 -0000 Received: (qmail 31198 invoked by uid 22791); 29 Sep 2011 11:25:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-gy0-f169.google.com (HELO mail-gy0-f169.google.com) (209.85.160.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 11:25:22 +0000 Received: by gya6 with SMTP id 6so524593gya.0 for ; Thu, 29 Sep 2011 04:25:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.4.103 with SMTP id j7mr46348533pbj.13.1317295521937; Thu, 29 Sep 2011 04:25:21 -0700 (PDT) Received: by 10.143.147.12 with HTTP; Thu, 29 Sep 2011 04:25:21 -0700 (PDT) In-Reply-To: <201109291210.01022.pedro@codesourcery.com> References: <201109291210.01022.pedro@codesourcery.com> Date: Thu, 29 Sep 2011 11:49:00 -0000 Message-ID: Subject: Re: [PATCH] [PR 9514] Fixing parse error for "pointer to a function pointer" From: Abhijit Halder To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec520e615a63a0d04ae12c3b4 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00524.txt.bz2 --bcaec520e615a63a0d04ae12c3b4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1424 On Thu, Sep 29, 2011 at 4:40 PM, Pedro Alves wrote: > On Thursday 29 September 2011 11:44:04, Abhijit Halder wrote: >> On Thu, Sep 29, 2011 at 4:10 PM, Abhijit Halder >> wrote: >> > Hi all, >> > >> > The current patch is to fix the issue defined in PR 9514. There's no >> > regression. Please review this. >> > >> > Thanks, >> > Abhijit Halder >> > >> >> Oops! The ChangeLog is incorrect. Correcting the same. > > Please always post both ChangeLog and patch together. =A0It's > practically 0 work to repost the whole thing instead of just a > part, while having all pieces together is easier for review, as > it avoids the reviewer, not being as familiar with the patches > as you, having to hunt for the pieces. =A0Also, please always try > to give explanations of what was wrong in the current code, and how > you're fixing the problem. =A0If you found a problem with an earlier > patch attempt, it's quite useful to know why that earlier patch didn't > work. =A0If a reviewer will need to try out a patch and go through > the same debug/thought process you had to go throught when writting > the patch, then it's more likely a patch will go by unreviewed > for longer. =A0In a nutshell, your job is to make it easy to get an OK. > > -- > Pedro Alves > Yes the got the point. I am re-submitting the whole thing once again for ease of review. Thanks, Abhijit Halder --bcaec520e615a63a0d04ae12c3b4 Content-Type: text/plain; charset=US-ASCII; name="ChangeLog.txt" Content-Disposition: attachment; filename="ChangeLog.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt5nokh90 Content-length: 216 MjAxMS0wOS0yOSAgQWJoaWppdCBIYWxkZXIgIDxhYmhpaml0LmsuaGFsZGVy QGdtYWlsLmNvbT4KCglGaXggUFIgZ2RiLzk1MTQ6CgkqIGMtZXhwLnkgKGFi c19kZWNsKTogQWRkIG5ldyBydWxlIHRvIHJlc29sdmUgcG9pbnRlcihzKSB0 byBhCglmdW5jdGlvbiBwb2ludGVyLgo= --bcaec520e615a63a0d04ae12c3b4 Content-Type: text/x-patch; charset=US-ASCII; name="gdb-parse-error.patch" Content-Disposition: attachment; filename="gdb-parse-error.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt5npc3d1 Content-length: 692 SW5kZXg6IGdkYi9jLWV4cC55Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNT IGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvYy1leHAueSx2CnJldHJpZXZpbmcg cmV2aXNpb24gMS44MgpkaWZmIC1hIC1wIC11IC1yMS44MiBjLWV4cC55Ci0t LSBnZGIvYy1leHAueQk2IE1heSAyMDExIDE0OjEyOjE3IC0wMDAwCTEuODIK KysrIGdkYi9jLWV4cC55CTI5IFNlcCAyMDExIDEwOjI2OjIwIC0wMDAwCkBA IC05MjYsNiArOTI2LDggQEAgY29uc3Rfb3Jfdm9sYXRpbGVfb3Jfc3BhY2Vf aWRlbnRpZmllcjogCiAKIGFic19kZWNsOgknKicKIAkJCXsgcHVzaF90eXBl ICh0cF9wb2ludGVyKTsgJCQgPSAwOyB9CisJfAlhYnNfZGVjbCAnKicKKwkJ CXsgcHVzaF90eXBlICh0cF9wb2ludGVyKTsgJCQgPSAkMTsgfQogCXwJJyon IGFic19kZWNsCiAJCQl7IHB1c2hfdHlwZSAodHBfcG9pbnRlcik7ICQkID0g JDI7IH0KIAl8CScmJwo= --bcaec520e615a63a0d04ae12c3b4--