From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16954 invoked by alias); 12 Sep 2011 15:30:29 -0000 Received: (qmail 16946 invoked by uid 22791); 12 Sep 2011 15:30:28 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-ew0-f41.google.com (HELO mail-ew0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Sep 2011 15:30:08 +0000 Received: by ewy9 with SMTP id 9so2001172ewy.0 for ; Mon, 12 Sep 2011 08:30:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.169.74 with SMTP id m52mr2569804wel.33.1315841406670; Mon, 12 Sep 2011 08:30:06 -0700 (PDT) Received: by 10.216.159.205 with HTTP; Mon, 12 Sep 2011 08:30:06 -0700 (PDT) In-Reply-To: <201109121623.04292.pedro@codesourcery.com> References: <201109121623.04292.pedro@codesourcery.com> Date: Mon, 12 Sep 2011 16:05:00 -0000 Message-ID: Subject: Re: Some code-cleanup From: Abhijit Halder To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016367fb52fa0162704acc033a7 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00198.txt.bz2 --0016367fb52fa0162704acc033a7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1732 On Mon, Sep 12, 2011 at 8:53 PM, Pedro Alves wrote: > On Monday 12 September 2011 16:05:59, Abhijit Halder wrote: >> I have seen in one place (write_exp_elt) that we are passing an union >> by value and not by reference. >> Please let me know whether we do have any specific reason of doing >> that. I am submitting the patch as an attachment. Please review the >> same. >> > > See : > > --0016364d2c7965a8ac04acbfddf0 > Content-Type: application/octet-stream; name=3Dpatch > Content-Disposition: attachment; filename=3Dpatch > Content-Transfer-Encoding: base64 > X-Attachment-Id: f_gshl4bmu0 > > Please teach your browser to attach files to gmail as > some text based content type, like patch/diff or > text/x-patch. =A0It may just be a matter of renaming > the files to have a ".diff" or ".patch" extension before > attaching them. =A0If not, you may need to teach your browser > about the mime type of .diff/.patch. > > You can see which mime type gmail gives your patch > before actually sending the email. =A0Just let gmail complete > the patch upload, and you should then see something like > > [X] foo.diff (text/x-patch) 5K > > It also affects the mail archives, check the difference, > both sent from gmail with files attached: > > =A0 > =A0 > > (follow the "Raw text" link too) > > -- > Pedro Alves > Sorry for this blunder! Re-submitting this once again with corrected file extension. Thanks, Abhijit Halder --0016367fb52fa0162704acc033a7 Content-Type: text/x-patch; charset=US-ASCII; name="code-cleanup.patch" Content-Disposition: attachment; filename="code-cleanup.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gshlzb6b0 Content-length: 6279 SW5kZXg6IGdkYi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9DaGFuZ2VMb2csdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMTMzMjAKZGlmZiAtdSAtcCAtcjEuMTMzMjAgQ2hh bmdlTG9nCi0tLSBnZGIvQ2hhbmdlTG9nCTExIFNlcCAyMDExIDA5OjU0OjE2 IC0wMDAwCTEuMTMzMjAKKysrIGdkYi9DaGFuZ2VMb2cJMTIgU2VwIDIwMTEg MTU6MjU6NDUgLTAwMDAKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wOS0xMiAg QWJoaWppdCBIYWxkZXIgIDxhYmhpaml0LmsuaGFsZGVyQGdtYWlsLmNvbT4K KworCUNvZGUgY2xlYW51cC4KKwkqIGdkYi9wYXJzZS5jICh3cml0ZV9leHBf ZWx0KTogQ2hhbmdlIHRoZSBhcmd1bWVudCB0byBwYXNzIGEgcG9pbnRlcgor CW9mIHVuaW9uIGV4cF9lbGVtZW50IGluc3RlYWQgb2YgYW4gZWxlbWVudCBv ZiB0aGUgc2FtZS4KKwkqICh3cml0ZV9leHBfZWx0X29wY29kZSk6IENoYW5n ZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0IGNhbGwuCisJKiAod3JpdGVf ZXhwX2VsdF9zeW0pOiBDaGFuZ2UgYXJndW1lbnQgb2Ygd3JpdGVfZXhwX2Vs dCBjYWxsLgorCSogKHdyaXRlX2V4cF9lbHRfYmxvY2spOiBDaGFuZ2UgYXJn dW1lbnQgb2Ygd3JpdGVfZXhwX2VsdCBjYWxsLgorCSogKHdyaXRlX2V4cF9l bHRfb2JqZmlsZSk6IENoYW5nZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0 IGNhbGwuCisJKiAod3JpdGVfZXhwX2VsdF9sb25nY3N0KTogQ2hhbmdlIGFy Z3VtZW50IG9mIHdyaXRlX2V4cF9lbHQgY2FsbC4KKwkqICh3cml0ZV9leHBf ZWx0X2RibGNzdCk6IENoYW5nZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0 IGNhbGwuCisJKiAod3JpdGVfZXhwX2VsdF9kZWNmbG9hdGNzdCk6IENoYW5n ZSBhcmd1bWVudCBvZiB3cml0ZV9leHBfZWx0IGNhbGwuCisJKiAod3JpdGVf ZXhwX2VsdF90eXBlKTogQ2hhbmdlIGFyZ3VtZW50IG9mIHdyaXRlX2V4cF9l bHQgY2FsbC4KKwkqICh3cml0ZV9leHBfZWx0X2ludGVybik6IENoYW5nZSBh cmd1bWVudCBvZiB3cml0ZV9leHBfZWx0IGNhbGwuCisJKiBzcmMvc2ltL3Bw Yy9kcC1iaXQuYyAodW5wYWNrX2QpOiBDaGFuZ2UgdGhlIGZvcm1hdHRpbmcu CisKIDIwMTEtMDktMTEgIEphbiBLcmF0b2NodmlsICA8amFuLmtyYXRvY2h2 aWxAcmVkaGF0LmNvbT4KIAogCUNvZGUgY2xlYW51cC4KSW5kZXg6IGdkYi9w YXJzZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv c3JjL3NyYy9nZGIvcGFyc2UuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4x MTAKZGlmZiAtdSAtcCAtcjEuMTEwIHBhcnNlLmMKLS0tIGdkYi9wYXJzZS5j CTE3IEp1biAyMDExIDIwOjI0OjIyIC0wMDAwCTEuMTEwCisrKyBnZGIvcGFy c2UuYwkxMiBTZXAgMjAxMSAxNToyNTo0NiAtMDAwMApAQCAtMTkwLDcgKzE5 MCw3IEBAIGZyZWVfZnVuY2FsbHMgKHZvaWQgKmlnbm9yZSkKICAgICB9CiB9 CiAMCi0vKiBUaGlzIHBhZ2UgY29udGFpbnMgdGhlIGZ1bmN0aW9ucyBmb3Ig YWRkaW5nIGRhdGEgdG8gdGhlICBzdHJ1Y3QgZXhwcmVzc2lvbgorLyogVGhp cyBwYWdlIGNvbnRhaW5zIHRoZSBmdW5jdGlvbnMgZm9yIGFkZGluZyBkYXRh IHRvIHRoZSBzdHJ1Y3QgZXhwcmVzc2lvbgogICAgYmVpbmcgY29uc3RydWN0 ZWQuICAqLwogCiAvKiBBZGQgb25lIGVsZW1lbnQgdG8gdGhlIGVuZCBvZiB0 aGUgZXhwcmVzc2lvbi4gICovCkBAIC0xOTksNyArMTk5LDcgQEAgZnJlZV9m dW5jYWxscyAodm9pZCAqaWdub3JlKQogICAgYSByZWdpc3RlciB0aHJvdWdo IGhlcmUuICAqLwogCiB2b2lkCi13cml0ZV9leHBfZWx0ICh1bmlvbiBleHBf ZWxlbWVudCBleHBlbHQpCit3cml0ZV9leHBfZWx0ICh1bmlvbiBleHBfZWxl bWVudCAqZXhwZWx0KQogewogICBpZiAoZXhwb3V0X3B0ciA+PSBleHBvdXRf c2l6ZSkKICAgICB7CkBAIC0yMDgsNyArMjA4LDcgQEAgd3JpdGVfZXhwX2Vs dCAodW5pb24gZXhwX2VsZW1lbnQgZXhwZWx0KQogCXhyZWFsbG9jICgoY2hh ciAqKSBleHBvdXQsIHNpemVvZiAoc3RydWN0IGV4cHJlc3Npb24pCiAJCSAg KyBFWFBfRUxFTV9UT19CWVRFUyAoZXhwb3V0X3NpemUpKTsKICAgICB9Ci0g IGV4cG91dC0+ZWx0c1tleHBvdXRfcHRyKytdID0gZXhwZWx0OworICBleHBv dXQtPmVsdHNbZXhwb3V0X3B0cisrXSA9ICpleHBlbHQ7CiB9CiAKIHZvaWQK QEAgLTIxOCw3ICsyMTgsNyBAQCB3cml0ZV9leHBfZWx0X29wY29kZSAoZW51 bSBleHBfb3Bjb2RlIGV4CiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2Yg KHVuaW9uIGV4cF9lbGVtZW50KSk7CiAgIHRtcC5vcGNvZGUgPSBleHBlbHQ7 Ci0gIHdyaXRlX2V4cF9lbHQgKHRtcCk7CisgIHdyaXRlX2V4cF9lbHQgKCZ0 bXApOwogfQogCiB2b2lkCkBAIC0yMjgsNyArMjI4LDcgQEAgd3JpdGVfZXhw X2VsdF9zeW0gKHN0cnVjdCBzeW1ib2wgKmV4cGVsdAogCiAgIG1lbXNldCAo JnRtcCwgMCwgc2l6ZW9mICh1bmlvbiBleHBfZWxlbWVudCkpOwogICB0bXAu c3ltYm9sID0gZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3 cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogdm9pZApAQCAtMjM4LDcgKzIz OCw3IEBAIHdyaXRlX2V4cF9lbHRfYmxvY2sgKHN0cnVjdCBibG9jayAqYikK IAogICBtZW1zZXQgKCZ0bXAsIDAsIHNpemVvZiAodW5pb24gZXhwX2VsZW1l bnQpKTsKICAgdG1wLmJsb2NrID0gYjsKLSAgd3JpdGVfZXhwX2VsdCAodG1w KTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI0 OCw3ICsyNDgsNyBAQCB3cml0ZV9leHBfZWx0X29iamZpbGUgKHN0cnVjdCBv YmpmaWxlICpvCiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9u IGV4cF9lbGVtZW50KSk7CiAgIHRtcC5vYmpmaWxlID0gb2JqZmlsZTsKLSAg d3JpdGVfZXhwX2VsdCAodG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7 CiB9CiAKIHZvaWQKQEAgLTI1OCw3ICsyNTgsNyBAQCB3cml0ZV9leHBfZWx0 X2xvbmdjc3QgKExPTkdFU1QgZXhwZWx0KQogCiAgIG1lbXNldCAoJnRtcCwg MCwgc2l6ZW9mICh1bmlvbiBleHBfZWxlbWVudCkpOwogICB0bXAubG9uZ2Nv bnN0ID0gZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3cml0 ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogdm9pZApAQCAtMjY4LDcgKzI2OCw3 IEBAIHdyaXRlX2V4cF9lbHRfZGJsY3N0IChET1VCTEVTVCBleHBlbHQpCiAK ICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9uIGV4cF9lbGVtZW50 KSk7CiAgIHRtcC5kb3VibGVjb25zdCA9IGV4cGVsdDsKLSAgd3JpdGVfZXhw X2VsdCAodG1wKTsKKyAgd3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZv aWQKQEAgLTI4MCw3ICsyODAsNyBAQCB3cml0ZV9leHBfZWx0X2RlY2Zsb2F0 Y3N0IChnZGJfYnl0ZSBleHBlCiAgIGZvciAoaW5kZXggPSAwOyBpbmRleCA8 IDE2OyBpbmRleCsrKQogICAgIHRtcC5kZWNmbG9hdGNvbnN0W2luZGV4XSA9 IGV4cGVsdFtpbmRleF07CiAKLSAgd3JpdGVfZXhwX2VsdCAodG1wKTsKKyAg d3JpdGVfZXhwX2VsdCAoJnRtcCk7CiB9CiAKIHZvaWQKQEAgLTI5MCw3ICsy OTAsNyBAQCB3cml0ZV9leHBfZWx0X3R5cGUgKHN0cnVjdCB0eXBlICpleHBl bHQpCiAKICAgbWVtc2V0ICgmdG1wLCAwLCBzaXplb2YgKHVuaW9uIGV4cF9l bGVtZW50KSk7CiAgIHRtcC50eXBlID0gZXhwZWx0OwotICB3cml0ZV9leHBf ZWx0ICh0bXApOworICB3cml0ZV9leHBfZWx0ICgmdG1wKTsKIH0KIAogdm9p ZApAQCAtMzAwLDcgKzMwMCw3IEBAIHdyaXRlX2V4cF9lbHRfaW50ZXJuIChz dHJ1Y3QgaW50ZXJuYWx2YXIKIAogICBtZW1zZXQgKCZ0bXAsIDAsIHNpemVv ZiAodW5pb24gZXhwX2VsZW1lbnQpKTsKICAgdG1wLmludGVybmFsdmFyID0g ZXhwZWx0OwotICB3cml0ZV9leHBfZWx0ICh0bXApOworICB3cml0ZV9leHBf ZWx0ICgmdG1wKTsKIH0KIAogLyogQWRkIGEgc3RyaW5nIGNvbnN0YW50IHRv IHRoZSBlbmQgb2YgdGhlIGV4cHJlc3Npb24uCkluZGV4OiBzaW0vcHBjL2Rw LWJpdC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv c3JjL3NyYy9zaW0vcHBjL2RwLWJpdC5jLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjcKZGlmZiAtdSAtcCAtcjEuNyBkcC1iaXQuYwotLS0gc2ltL3BwYy9k cC1iaXQuYwkxIEphbiAyMDExIDE1OjM0OjA0IC0wMDAwCTEuNworKysgc2lt L3BwYy9kcC1iaXQuYwkxMiBTZXAgMjAxMSAxNToyNTo0OSAtMDAwMApAQCAt NDA4LDcgKzQwOCw3IEBAIHBhY2tfZCAoIGZwX251bWJlcl90eXBlICogIHNy YykKIH0KIAogc3RhdGljIHZvaWQKLXVucGFja19kIChGTE9fdW5pb25fdHlw ZSAqIHNyYywgZnBfbnVtYmVyX3R5cGUgKiBkc3QpCit1bnBhY2tfZCAoRkxP X3VuaW9uX3R5cGUgKnNyYywgZnBfbnVtYmVyX3R5cGUgKmRzdCkKIHsKICAg ZnJhY3R5cGUgZnJhY3Rpb24gPSBzcmMtPmJpdHMuZnJhY3Rpb247CiAK --0016367fb52fa0162704acc033a7--